Repository navigation
Discover tests in a fork when a toolchain JDK is used - #3444
Merged
olamy merged 2 commits intoAug 25, 2026
Merged
Conversation
When forking has to list the tests first (forkCount > 1 or reuseForks=false), Surefire did it in Maven's JVM. If the tests were built for a newer JDK, that failed with UnsupportedClassVersionError. Now the listing runs in a short-lived fork using the toolchain JDK, so no test class is loaded in Maven's JVM. The extra fork only starts when the test JVM differs from Maven's. Fixes apache#2151 Signed-off-by: Olivier Lamy <olamy@apache.org>
Signed-off-by: Olivier Lamy <olamy@apache.org>
4 of 6 tasks
This was referenced Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When forking has to list the tests first (forkCount > 1 or
reuseForks=false), Surefire did it in Maven's JVM. If the tests were
built for a newer JDK, that failed with UnsupportedClassVersionError.
Now the listing runs in a short-lived fork using the toolchain JDK, so
no test class is loaded in Maven's JVM. The extra fork only starts when
the test JVM differs from Maven's.
Fixes #2151
Signed-off-by: Olivier Lamy olamy@apache.org
Following this checklist to help us incorporate your
contribution quickly and easily:
mvn clean installto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean install).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.