Repository navigation
Implement getOutputPath() and deprecate getOutputName() - #3469
Merged
Merged
Conversation
Maven Reporting API 4.0.0 keeps getOutputName() abstract, so it cannot simply be renamed: it stays, deprecated, delegating to the new method. Do not collapse the pair until the API drops getOutputName().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts the report output method that Maven Reporting API 4.0.0 introduced, following the pattern in the report plugin guide and already used by maven-javadoc-plugin and maven-pmd-plugin:
getOutputPath()carries the value, andgetOutputName()stays as a deprecated delegate because the API still declares it abstract.Both reports return the configurable
outputNameparameter as before, so the rendered paths do not change.AbstractSurefireReportnow declaresgetOutputPath()abstract instead ofgetOutputName().The
surefire-3.5.xline is not touched: it is the Doxia 1 line for this plugin and Maven Reporting API 3.x has nogetOutputPath().Verified:
mvn test -pl maven-surefire-report-plugin→ 14 tests, 0 failures.This change was created with AI assistance.