Repository navigation
[pylint] Gate ImportCycleError on Python 3.15 (PLW0133) - #28310
Merged
ntBre merged 1 commit intoSep 4, 2026
Merged
Conversation
|
|
ntBre
reviewed
Sep 4, 2026
ntBre
left a comment
ntBre
left a comment
Contributor
There was a problem hiding this comment.
Thanks, the code change looks correct. I just had a couple of suggestions about the testing setup.
ntBre
added
bug
gorewilliams
force-pushed
the
fix-plw0133-import-cycle-error-version
branch
from
September 4, 2026 19:33
7bf5c29 to
84363a3
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix PLW0133's Python version gating for
ImportCycleError.ImportCycleErrorwas added in Python 3.15, but Ruff currently treats it as available starting in Python 3.13.This updates the builtin exception classification so that:
PythonFinalizationErrorremains available for Python 3.13+ImportCycleErroris only considered available for Python 3.15+Also adds regression coverage for the behavior across target Python versions.
Closes part of #28206.