Repository navigation
Conversation
`flake8-type-checking.runtime-evaluated-decorators` erroneously applied runtime semantics to all annotation assignments inside a function scope. Annotation assignments inside function scopes never result in any actual code for the annotation expressions, they get silently dropped by the compiler and are missing completely from the resulting byte code, so they can never be anything other than typing-only.
Daverball
changed the title
flake8-type-checking] Never flags annotation in function scopesflake8-type-checking] Never flag annotations in function scopes
|
ntBre
approved these changes
Oct 7, 2026
ntBre
added
the
bug
ntBre
enabled auto-merge (squash)
October 7, 2026 15:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29182
Summary
flake8-type-checking.runtime-evaluated-decoratorserroneously applied runtime semantics to all annotation assignments inside a function scope. Annotation assignments inside function scopes never result in any actual code for the annotation expressions, they get silently dropped by the compiler and are missing completely from the resulting byte code, so they can never be anything other than typing-only.Test Plan
cargo nextest run