Repository navigation
Honor CLICOLOR=0 in Ruff and ty diagnostics - #29910
Merged
Merged
Conversation
AlexWaygood
added
cli
AlexWaygood
temporarily deployed
to
automations
November 2, 2026 15:38 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
AlexWaygood
changed the title
CLICOLOR=0 in Ruff and ty diagnosticsCLICOLOR=0 in Ruff and ty diagnostics
Contributor
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 98.60%. The percentage of expected errors that received a diagnostic held steady at 98.86%. The number of fully passing files held steady at 137/146. Results for 598bfc4 · Workflow run |
Contributor
Memory usage reportMemory usage unchanged ✅ Results for 598bfc4 · Workflow run |
Contributor
|
Contributor
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CLICOLOR=0 ruff checkandCLICOLOR=0 ty checkcurrently print colored diagnostics on a terminal because both commands treat0like any other non-emptyCLICOLORvalue. This change makesCLICOLOR=0disable color, as Micha requested on #29898.A non-empty
FORCE_COLORorCLICOLOR_FORCEstill takes precedence overCLICOLOR. For example,CLICOLOR=0 FORCE_COLOR=0 ty checkstill forces color, even in a pipe.