Repository navigation
Collect return statements with a statement-only visitor - #29911
Merged
Merged
Conversation
MichaReiser
added
performance
MichaReiser
temporarily deployed
to
automations
November 2, 2026 15:39 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
|
MichaReiser
force-pushed
the
micha/plr0911-count-returns
branch
from
November 2, 2026 16:22
c437589 to
75ceec9
Compare
MichaReiser
changed the title
MichaReiser
temporarily deployed
to
automations
November 2, 2026 16:23 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
Memory usage reportMemory usage unchanged ✅ Results for 2344dd3 · Workflow run |
Contributor
|
MichaReiser
force-pushed
the
micha/plr0911-count-returns
branch
from
November 2, 2026 16:32
75ceec9 to
c437589
Compare
MichaReiser
changed the title
MichaReiser
temporarily deployed
to
automations
November 2, 2026 16:34 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
MichaReiser
changed the title
MichaReiser
temporarily deployed
to
automations
November 2, 2026 17:01 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
MichaReiser
commented
Nov 2, 2026
| } | ||
|
|
||
| #[derive(Default)] | ||
| struct ReturnTypeVisitor<'a> { |
Member
Author
There was a problem hiding this comment.
This rule also needs to know whether a body contains a generator expression. It's the only rule, which is why we inlined the expression-visiting implementation here
MichaReiser
marked this pull request as ready for review
November 2, 2026 17:04
ntBre
approved these changes
Nov 2, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Eleven lint checks collect
returnstatements from the current function. Their visitor now skips expressions as well as nested functions and classes. The annotation fixer keeps its existing visitor because it also needs to detectyieldandyield frombefore suggesting a return type.For PLR0911 alone, 196 calls with all stable rules enabled, this cuts instructions from 323,004 to 64,650 (−79.98%)
Test Plan
The existing Ruff linter unit suite passes with no snapshot changes.