Repository navigation
Reuse a callee's qualified name across lint rules - #29916
Merged
Merged
Conversation
MichaReiser
temporarily deployed
to
automations
November 2, 2026 18:18 — with
GitHub Actions
Inactive
Contributor
|
Merging this PR will improve performance by 7.28%
Performance Changes
Tip Curious why performance improved? Comment Comparing Footnotes
|
MichaReiser
temporarily deployed
to
automations
November 3, 2026 08:34 — with
GitHub Actions
Inactive
MichaReiser
marked this pull request as ready for review
November 3, 2026 08:53
ntBre
approved these changes
Nov 3, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Several lint rules can resolve the same callee while checking a single call. For example, with
import numpy as np, they can each look upnp.random.randintinnp.random.randint(10). The call checker now resolves the callee once if any rule in the group is enabled, skips the group if resolution fails, and passes the qualified name to each enabled handler.The first three rows count native arm64 instructions spent linting Ruffβs five benchmark files, with parsing and setup excluded. The last row counts the whole
ruff checkprocess over 686 Python 3.12 standard-library files with default rules and caching disabled.Test Plan
The linter and semantic-model tests passed, and 1,711 rule fixtures produced the same diagnostics and applied fixes, allowing for display order at tied source offsets.