Repository navigation
Show more nonprinting characters in diagnostic fix diffs - #30062
Merged
Merged
Conversation
MichaReiser
added
the
diagnostics
MichaReiser
temporarily deployed
to
automations
November 5, 2026 10:20 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
Memory usage reportMemory usage unchanged ✅ Results for 81a33cf · Workflow run |
MichaReiser
changed the title
Contributor
|
Contributor
|
ntBre
approved these changes
Nov 5, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After #30017,
ruff format --checkshows a deletion for a file containing only a byte order mark (BOM), but the deleted line looks empty. Render the BOM as�so the deletion is visible.Fix diffs also show ASCII controls such as NUL as
␀, display bidirectional formatting controls as�, and omit zero-width joiners. This aligns our behavior with annotated snippets, with the exception of tabs (I left that unchanged for now). We could use the helper provided by annotated snippets if we decide to also replace tab characters with four spaces.Test Plan
Updated the formatter and linter snapshots and ran the CLI, diagnostic renderer, and linter tests.