Repository navigation
fix: allow whitespace in uv requirement specifiers - #1112
Merged
eifinger merged 2 commits intoOct 26, 2026
Merged
Conversation
PEP 508 allows whitespace around version operators and between clauses. `uv >= 0.5` was ignored and the latest version installed, and `uv>=0.5, <0.6` was read as `>=0.5,`, which fails to resolve. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
eifinger
requested changes
Oct 25, 2026
| function getUvVersionFromDependency(dependency: string): string | undefined { | ||
| const dependencyWithoutMarker = dependency.split(";", 1)[0]?.trim(); | ||
| return dependencyWithoutMarker?.match(/^uv([=<>~!]+\S*)/)?.[1].trim(); | ||
| // PEP 508 allows whitespace around operators and between clauses, e.g. "uv >= 0.5, < 0.6" |
Collaborator
There was a problem hiding this comment.
Please remove this comment. It is an explanation for the change we made that belongs in a commit message body or the PR description.
luketainton
pushed a commit
to luketainton/luke_rsu
that referenced
this pull request
Oct 28, 2026
![renovate[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [astral-sh/setup-uv](https://github.com/astral-sh/setup-uv) | action | patch | `v10.3.2` → `v10.3.3` | --- ### Release Notes <details> <summary>astral-sh/setup-uv</summary> ### [`v10.3.3`](https://github.com/astral-sh/setup-uv/releases/tag/v10.3.3): 🌈 Use Astral mirror for version manifests with GitHub fallback [Compare Source](astral-sh/setup-uv@v10.3.2...v10.3.3) ##### Changes This release contains something that should have been included a very long time ago. Sorry for sleeping on that. This action now retrieves the release manifest that contains the available versions, their download links and checksums from the Astral mirror, rather than trying GitHub first. This should present much more stable. (Known checksums are still checked, so the security impact does not change) Also a big thank you to [@​soujasK](https://github.com/soujasK) for a set of bugfixes 👏 ##### 🐛 Bug fixes - Use Astral mirror for version manifests with GitHub fallback [@​eifinger](https://github.com/eifinger) ([#​1119](astral-sh/setup-uv#1119)) - fix: allow whitespace in uv requirement specifiers [@​soujasK](https://github.com/soujasK) ([#​1112](astral-sh/setup-uv#1112)) - fix: resolve \~= specifiers with PEP 440 semantics [@​soujasK](https://github.com/soujasK) ([#​1111](astral-sh/setup-uv#1111)) - fix: only report a saved cache when saving succeeded [@​soujasK](https://github.com/soujasK) ([#​1110](astral-sh/setup-uv#1110)) ##### 🧰 Maintenance - chore: update known checksums for 0.13.6 @​[github-actions\[bot\]](https://github.com/apps/github-actions) ([#​1117](astral-sh/setup-uv#1117)) ##### 📚 Documentation - docs: use JSDoc for compatible release specifier comment [@​eifinger](https://github.com/eifinger) ([#​1113](astral-sh/setup-uv#1113)) - docs: update version references to v10.3.2 @​[github-actions\[bot\]](https://github.com/apps/github-actions) ([#​1104](astral-sh/setup-uv#1104)) </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4xOTAuMCIsInVwZGF0ZWRJblZlciI6IjQ0LjE5MC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL2RlcGVuZGVuY2llcyJdfQ==--> Reviewed-on: https://git.tainton.uk/repos/rsu/pulls/64 Co-authored-by: renovate[bot] <renovate-bot@git.tainton.uk>
luketainton
pushed a commit
to luketainton/repos_labmcp
that referenced
this pull request
Oct 28, 2026
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [astral-sh/setup-uv](https://github.com/astral-sh/setup-uv) | action | patch | `v10.3.2` → `v10.3.3` | --- ### Release Notes <details> <summary>astral-sh/setup-uv</summary> ### [`v10.3.3`](https://github.com/astral-sh/setup-uv/releases/tag/v10.3.3): 🌈 Use Astral mirror for version manifests with GitHub fallback [Compare Source](astral-sh/setup-uv@v10.3.2...v10.3.3) ##### Changes This release contains something that should have been included a very long time ago. Sorry for sleeping on that. This action now retrieves the release manifest that contains the available versions, their download links and checksums from the Astral mirror, rather than trying GitHub first. This should present much more stable. (Known checksums are still checked, so the security impact does not change) Also a big thank you to [@​soujasK](https://github.com/soujasK) for a set of bugfixes 👏 ##### 🐛 Bug fixes - Use Astral mirror for version manifests with GitHub fallback [@​eifinger](https://github.com/eifinger) ([#​1119](astral-sh/setup-uv#1119)) - fix: allow whitespace in uv requirement specifiers [@​soujasK](https://github.com/soujasK) ([#​1112](astral-sh/setup-uv#1112)) - fix: resolve \~= specifiers with PEP 440 semantics [@​soujasK](https://github.com/soujasK) ([#​1111](astral-sh/setup-uv#1111)) - fix: only report a saved cache when saving succeeded [@​soujasK](https://github.com/soujasK) ([#​1110](astral-sh/setup-uv#1110)) ##### 🧰 Maintenance - chore: update known checksums for 0.13.6 @​[github-actions\[bot\]](https://github.com/apps/github-actions) ([#​1117](astral-sh/setup-uv#1117)) ##### 📚 Documentation - docs: use JSDoc for compatible release specifier comment [@​eifinger](https://github.com/eifinger) ([#​1113](astral-sh/setup-uv#1113)) - docs: update version references to v10.3.2 @​[github-actions\[bot\]](https://github.com/apps/github-actions) ([#​1104](astral-sh/setup-uv#1104)) </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4xOTAuMCIsInVwZGF0ZWRJblZlciI6IjQ0LjE5MC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL2RlcGVuZGVuY2llcyJdfQ==--> Reviewed-on: https://git.tainton.uk/repos/labmcp/pulls/87 Reviewed-by: Luke Tainton <luke@tainton.uk> Co-authored-by: renovate[bot] <renovate-bot@git.tainton.uk>
Doridian
pushed a commit
to FoxDenHome/core
that referenced
this pull request
Oct 28, 2026
…10.3.3 (#288) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [https://github.com/astral-sh/setup-uv](https://github.com/astral-sh/setup-uv) | action | patch | `v10.3.2` → `v10.3.3` | --- ### Release Notes <details> <summary>astral-sh/setup-uv (https://github.com/astral-sh/setup-uv)</summary> ### [`v10.3.3`](https://github.com/astral-sh/setup-uv/releases/tag/v10.3.3): 🌈 Use Astral mirror for version manifests with GitHub fallback [Compare Source](astral-sh/setup-uv@v10.3.2...v10.3.3) #### Changes This release contains something that should have been included a very long time ago. Sorry for sleeping on that. This action now retrieves the release manifest that contains the available versions, their download links and checksums from the Astral mirror, rather than trying GitHub first. This should present much more stable. (Known checksums are still checked, so the security impact does not change) Also a big thank you to [@​soujasK](https://github.com/soujasK) for a set of bugfixes 👏 #### 🐛 Bug fixes - Use Astral mirror for version manifests with GitHub fallback [@​eifinger](https://github.com/eifinger) ([#​1119](astral-sh/setup-uv#1119)) - fix: allow whitespace in uv requirement specifiers [@​soujasK](https://github.com/soujasK) ([#​1112](astral-sh/setup-uv#1112)) - fix: resolve \~= specifiers with PEP 440 semantics [@​soujasK](https://github.com/soujasK) ([#​1111](astral-sh/setup-uv#1111)) - fix: only report a saved cache when saving succeeded [@​soujasK](https://github.com/soujasK) ([#​1110](astral-sh/setup-uv#1110)) #### 🧰 Maintenance - chore: update known checksums for 0.13.6 @​[github-actions\[bot\]](https://github.com/apps/github-actions) ([#​1117](astral-sh/setup-uv#1117)) #### 📚 Documentation - docs: use JSDoc for compatible release specifier comment [@​eifinger](https://github.com/eifinger) ([#​1113](astral-sh/setup-uv#1113)) - docs: update version references to v10.3.2 @​[github-actions\[bot\]](https://github.com/apps/github-actions) ([#​1104](astral-sh/setup-uv#1104)) </details> --- ### Configuration 📅 **Schedule**: (in timezone America/Los_Angeles) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4xOTAuMCIsInVwZGF0ZWRJblZlciI6IjQ0LjE5MC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Reviewed-on: https://git.foxden.network/FoxDen/core/pulls/288
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the uv version is read from dependencies (
requirements.txt, orproject.dependencies/optional-dependencies/dependency-groupsinpyproject.tomlviaversion-file), the specifier was matched with/^uv([=<>~!]+\S*)/. PEP 508 allows whitespace around operators and after commas, and those valid forms were misread:uv >= 0.5.0>=0.5.0uv == 0.11.20==0.11.20uv>=0.5.0, <0.6.0>=0.5.0,, fails withNo version found for >=0.5.0,>=0.5.0,<0.6.0The regex now allows whitespace around operators and between comma-separated clauses, and strips it from the result. Inputs that worked before give the same result, including inline
--hash=options, trailing# comments, the\continuation lines fromuv pip compile --generate-hashes, and names that only start withuv(uvicorn,uv-build).Test plan
--hashand trailing comments. The four whitespace cases failed before the change.npm run allon Ubuntu (WSL) with Node 24.19.0: build, Biome (no fixes), packaging, and 165 tests across 15 suites pass. The rebuiltdist/setup/index.cjsonly differs in the changed line.