🔥 Jadwal & Hasil: atuinsh/atuin/issues/

markovejnovic · 2026-10-22T00:44:21Z

Unix sockets and Windows' TCP port were told apart by cfgs across service/. Each platform's address module now defines the same names, so the code calling it has no cfgs of its own. The commit lists what moved where.

No behaviour change. Windows clients now pass --daemonize as well, which does nothing there. Some public items moved:

service::pidfile::SocketPathError is now service::address::LocateError, and Pidfile::socket_path is now DaemonAddress::locate.
client::potential_socket_paths is gone, and so is the service::RemoveSocketError re-export; use service::address::RemoveSocketError.
The pidfile's round-trip proptest now runs on Windows too, over UTF-8 paths only. AutoOsString's own tests round-trip the others.

Includes #4513, so review only the last commit.

macOS: clippy (default and --tests), rustdoc, atuin-daemon lib tests and e2e_daemon pass.
Linux (Docker): clippy and the atuin-common and atuin-daemon lib tests pass.
Windows (x86_64-pc-windows-gnu, cross-compiled): clippy is clean for atuin-daemon and cargo check --tests passes. Clippy on the atuin binary fails with the same 10 errors as main. Not run on Windows itself.

Stack (bottom → top)

fix(daemon): spare a stale pidfile's PID when evicting #4512 fix(daemon): spare a stale pidfile's PID when evicting
feat(common): find a process's cgroup under cgroup v1 and v2 #4513 feat(common): find a process's cgroup under cgroup v1 and v2
refactor(daemon): keep where the daemon listens behind service::address #4514 refactor(daemon): keep where the daemon listens behind service::address
refactor(daemon): take up the daemon's socket in SocketHolder, not Backend #4515 refactor(daemon): take up the daemon's socket in SocketHolder, not Backend
fix(daemon): handle daemons not spawned by atuin #4516 feat(daemon): leave a daemon that something else runs to it
feat(daemon): run the daemon as a launchd agent on macOS #4517 feat(daemon): run the daemon as a launchd agent on macOS

Each PR includes the ones below it. Review and merge bottom-up.

greptile-apps · 2026-10-22T00:49:20Z

Confidence Score: 4/5

[Medium impact] The changes reach daemon startup, connection, and cleanup across Unix and Windows.

The refactor appears behavior-preserving, but the existing test-convention requirement must be satisfied before merging.

Findings

Test misses required convention ▶

Summary

Moves platform-specific daemon addresses and socket cleanup behind service::address.

The daemon gets its listening address and socket-file work through one platform-specific interface.
Daemon startup uses the same detach option on both platforms.

_{Reviews (2) · Last reviewed commit: "refactor(daemon): keep where the daemon ..." · Reviewed by Greptile}

greptile-apps · 2026-10-22T00:49:23Z

            version in ".*",
-            socket_path in proptest::option::of(path_buf()),
+            // `AutoOsString`'s own tests round-trip the paths that aren't UTF-8.
+            socket_path in proptest::option::of(".*".prop_map(PathBuf::from)),


Test misses required convention

The edited prop_parse_round_trip still uses #[test]. AGENTS.md requires #[rstest] for every test and explicitly requires migrating bare #[test] attributes in touched files. Replace the attribute above this test with #[rstest] before merging; a_list_round_trips already uses that pattern inside proptest!.

Context Used: AGENTS.md (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

`atuin daemon start --force` evicts the running daemon before starting its own, and it killed the PID in the pidfile even when no daemon held the pidfile. A daemon that crashed leaves its pidfile behind, and its PID may since have gone to another process. Evicting now signals the PID only while a daemon holds the pidfile. The regression test dies by SIGTERM without the fix. ## Stack (bottom → top) 1. #4512 fix(daemon): spare a stale pidfile's PID when evicting 2. #4513 feat(common): parse a process's cgroups under cgroup v1 and v2 3. #4514 refactor(daemon): keep where the daemon listens behind service::address 4. #4515 refactor(daemon): take up the daemon's socket in SocketHolder, not Backend 5. #4516 feat(daemon): leave a daemon that something else runs to it 6. #4517 feat(daemon): run the daemon as a launchd agent on macOS Each PR includes the ones below it. Review and merge bottom-up.

`CgroupV2` finds a process's cgroup in cgroup v2's unified hierarchy, the `0::` line of `/proc/<pid>/cgroup`, and `CgroupV1` the one in the v1 hierarchy a controller or name is bound to, such as systemd's `name=systemd`. The hybrid layout lists both. RHEL 8 and its rebuilds (systemd 239, built with `-Ddefault-hierarchy=legacy`) boot cgroup v1 alone, with no `0::` line: the kernel lists v2's hierarchy only once something mounts it. Nothing calls them yet: a later PR in this stack uses them to tell whether a systemd user unit runs the daemon. `listed_in`'s cases pass in a standalone crate on macOS. The `reads_the_active_process` tests were not run on this version. ## Stack (bottom → top) 1. #4512 fix(daemon): spare a stale pidfile's PID when evicting 2. #4513 feat(common): find a process's cgroup under cgroup v1 and v2 3. #4514 refactor(daemon): keep where the daemon listens behind service::address 4. #4515 refactor(daemon): take up the daemon's socket in SocketHolder, not Backend 5. #4516 feat(daemon): leave a daemon that something else runs to it 6. #4517 feat(daemon): run the daemon as a launchd agent on macOS Each PR includes the ones below it. Review and merge bottom-up.

markovejnovic · 2026-10-22T02:24:30Z

/merge yolo

atuin-bot · 2026-10-22T02:25:28Z

Landed as 65aef2f without CI. GitHub shows this merged once it reaches main.

…ss (#4514) Unix sockets and Windows' TCP port were told apart by cfgs across `service/`. Each platform's `address` module now defines the same names, so the code calling it has no cfgs of its own. The commit lists what moved where. No behaviour change. Windows clients now pass `--daemonize` as well, which does nothing there. Some public items moved: - `service::pidfile::SocketPathError` is now `service::address::LocateError`, and `Pidfile::socket_path` is now `DaemonAddress::locate`. - `client::potential_socket_paths` is gone, and so is the `service::RemoveSocketError` re-export; use `service::address::RemoveSocketError`. - The pidfile's round-trip proptest now runs on Windows too, over UTF-8 paths only. `AutoOsString`'s own tests round-trip the others. Includes #4513, so review only the last commit. - macOS: clippy (default and `--tests`), rustdoc, `atuin-daemon` lib tests and `e2e_daemon` pass. - Linux (Docker): clippy and the `atuin-common` and `atuin-daemon` lib tests pass. - Windows (`x86_64-pc-windows-gnu`, cross-compiled): clippy is clean for `atuin-daemon` and `cargo check --tests` passes. Clippy on the `atuin` binary fails with the same 10 errors as main. Not run on Windows itself. ## Stack (bottom → top) 1. #4512 fix(daemon): spare a stale pidfile's PID when evicting 2. #4513 feat(common): find a process's cgroup under cgroup v1 and v2 3. #4514 refactor(daemon): keep where the daemon listens behind service::address 4. #4515 refactor(daemon): take up the daemon's socket in SocketHolder, not Backend 5. #4516 feat(daemon): leave a daemon that something else runs to it 6. #4517 feat(daemon): run the daemon as a launchd agent on macOS Each PR includes the ones below it. Review and merge bottom-up.

…ckend (#4515) `Backend::listen` ran inside the daemon, but backends belong to the client, which picks one to start and stop the daemon. Off Linux, `ExternalSystemd` built a `Subproc` only to bind its socket. `SocketHolder` now says who holds the socket, the daemon or systemd, and takes it up. Taking systemd's socket moves into `systemd/`, which off Linux has the daemon bind its own. No behaviour change. `ExternalSystemd` keeps its `cfg(unix)` gate until the next PR in this stack replaces it. Includes #4513 and #4514, so review only the last commit. Checked the same way as #4514. ## Stack (bottom → top) 1. #4512 fix(daemon): spare a stale pidfile's PID when evicting 2. #4513 feat(common): find a process's cgroup under cgroup v1 and v2 3. #4514 refactor(daemon): keep where the daemon listens behind service::address 4. #4515 refactor(daemon): take up the daemon's socket in SocketHolder, not Backend 5. #4516 feat(daemon): leave a daemon that something else runs to it 6. #4517 feat(daemon): run the daemon as a launchd agent on macOS Each PR includes the ones below it. Review and merge bottom-up.

### Bug Fixes - *(ai)* Import IntoStaticStr from strum_macros, not strum ([#4480](#4480)) - *(ai)* Improve detection of git repositories ([#4450](#4450)) - *(client)* Resolve relative config paths beside config.toml, not the cwd ([#4479](#4479)) - *(config)* Don't print errors twice ([#4501](#4501)) - *(daemon)* Fetch the server's capabilities until a fetch succeeds - *(daemon)* Spare a stale pidfile's PID when evicting ([#4512](#4512)) - *(daemon)* Handle daemons not spawned by atuin ([#4516](#4516)) - *(output)* Keep quoted words together in output search ([#4502](#4502)) - *(packfile)* Load only the records inside a manifest's range - *(pty-proxy)* Standalone init with `atuin pty-proxy init` ([#4449](#4449)) - *(pty-proxy)* Wait for input on a non-blocking inherited stdin ([#4486](#4486)) - *(pty-proxy)* Don't re-exec shells running commands from a string or file ([#4414](#4414)) - *(search)* Don't panic when copying with no results ([#4426](#4426)) - *(server)* Let `ATUIN_*` environment variables override server.toml ([#4456](#4456)) - *(update)* Accept ATUIN_GITHUB_TOKEN ([#4262](#4262)) - Remove duplicated word in the no-history stats message ([#4451](#4451)) - Error printing in `?` handler ([#4448](#4448)) - Normalize relative gitdir paths in worktree resolution ([#4506](#4506)) - Upgrade regressions found in release QA ([#4519](#4519)) ### Documentation - Fix ctrl_n_shortcuts default value ([#4458](#4458)) - List all history list --format variables ([#4460](#4460)) - Fix the --reverse default for history list ([#4472](#4472)) - Mention December default in wrapped --year help ([#4476](#4476)) ### Features - *(common)* AbsPath and AbsPathBuf, Path and PathBuf checked to be absolute ([#4481](#4481)) - *(common)* Find a process's cgroup under cgroup v1 and v2 ([#4513](#4513)) - *(daemon)* Run the daemon as a launchd agent on macOS ([#4517](#4517)) - *(pty-proxy)* Window title follows child process ([#4447](#4447)) - *(secrets)* Keep HashiCorp tokens out of history ([#4445](#4445)) ### Miscellaneous Tasks - Give mono its own nixfmt step and scope atuin's to atuin/ - Say a /merge's landed commit gets CI on main - Rebuild the apt .deb cache for Ubuntu 24.04 ([#4504](#4504)) - Remove the benchmarks ([#4511](#4511)) ### Performance - *(common)* Compile the vendor regexes once ([#4485](#4485)) - *(common)* Drop the tree watcher's file-id cache ([#4492](#4492)) - *(common)* Release a line reader's buffer at the end of the file ([#4494](#4494)) - *(common)* Keep no tree watcher entry for a rejected file ([#4493](#4493)) - *(daemon)* Warm up only a resumed session's unanswered calls ([#4490](#4490)) - *(packfile)* Compress packs in one shot ([#4484](#4484)) ### Refactor - *(daemon)* Managed daemon service with multiple backends ([#4488](#4488)) - *(daemon)* Move daemon startup into the service module ([#4503](#4503)) - *(daemon)* Keep where the daemon listens behind service::address ([#4514](#4514)) - *(daemon)* Take up the daemon's socket in SocketHolder, not Backend ([#4515](#4515)) - *(deps)* Bump clap_complete_nushell from 4.6.0 to 4.6.2 ([#4473](#4473)) - *(deps)* Bump clap_complete from 4.6.9 to 4.6.11 ([#4396](#4396)) - *(deps)* Bump ratatui from 0.30.0 to 0.30.2 ([#4474](#4474)) - *(deps)* Bump certifi from 2025.11.12 to 2026.10.19 in /docs in the uv group across 1 directory ([#4500](#4500)) - *(pty-proxy)* Run on tokio with the parser on its own runtime ([#4482](#4482)) - *(pty-proxy)* Forward captures to the daemon on the proxy's runtime ([#4487](#4487)) - *(pty-proxy)* Rename the screen's parser to Emulator ([#4510](#4510)) - *(pty-proxy)* Migrate output parsing to vte ([#4518](#4518)) ### Testing - *(daemon)* Run the output index tests under rstest ([#4496](#4496))

This was referenced Oct 22, 2026

refactor(daemon): take up the daemon's socket in SocketHolder, not Backend #4515

Merged

fix(daemon): handle daemons not spawned by atuin #4516

Merged

greptile-apps Bot reviewed Oct 22, 2026

View reviewed changes

This was referenced Oct 22, 2026

feat(daemon): run the daemon as a launchd agent on macOS #4517

Merged

fix(daemon): spare a stale pidfile's PID when evicting #4512

Merged

feat(common): find a process's cgroup under cgroup v1 and v2 #4513

Merged

markovejnovic force-pushed the refactor/daemon-address branch 3 times, most recently from 57561e2 to 9a93677 Compare October 22, 2026 01:56

markovejnovic changed the base branch from main to feat/common-cgroup October 22, 2026 02:02

atuin-bot force-pushed the feat/common-cgroup branch from 5cde405 to a483f50 Compare October 22, 2026 02:08

Base automatically changed from feat/common-cgroup to main October 22, 2026 02:08

markovejnovic force-pushed the refactor/daemon-address branch from 9a93677 to 2f8ec80 Compare October 22, 2026 02:18

markovejnovic marked this pull request as ready for review October 22, 2026 02:19

atuin-bot added mergebot:queued mergebot:running and removed mergebot:queued labels Oct 22, 2026

atuin-bot added the mergebot:merged label Oct 22, 2026

atuin-bot force-pushed the refactor/daemon-address branch from 2f8ec80 to 65aef2f Compare October 22, 2026 02:25

atuin-bot removed the mergebot:running label Oct 22, 2026

atuin-bot merged commit 65aef2f into main Oct 22, 2026
6 checks passed

atuin-bot deleted the refactor/daemon-address branch October 22, 2026 02:25

markovejnovic mentioned this pull request Oct 22, 2026

chore(release): prepare for release 18.24.2 #4520

Merged

snoopy82481-bot Bot mentioned this pull request Oct 22, 2026

fix(container): update image ghcr.io/atuinsh/atuin (18.24.1 ➔ 18.24.2) snoopy82481/home-cluster#3912

Merged

1 task

scottames-github-bot Bot mentioned this pull request Oct 26, 2026

chore(deps): update ⬆️ mise-packages scottames/dots#1123

Merged

1 task

Navigation Menu

Repository navigation

refactor(daemon): keep where the daemon listens behind service::address - #4514

refactor(daemon): keep where the daemon listens behind service::address#4514
atuin-bot merged 1 commit into
mainfrom
refactor/daemon-address

markovejnovic commented Oct 22, 2026 •

edited

Loading

Uh oh!

greptile-apps Bot commented Oct 22, 2026 •

edited

Loading

Uh oh!

greptile-apps Bot Oct 22, 2026

Uh oh!

markovejnovic commented Oct 22, 2026

Uh oh!

atuin-bot commented Oct 22, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

markovejnovic commented Oct 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Stack (bottom → top)

Uh oh!

greptile-apps Bot commented Oct 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 4/5

Findings

Summary

Uh oh!

greptile-apps Bot Oct 22, 2026

Choose a reason for hiding this comment

Uh oh!

markovejnovic commented Oct 22, 2026

Uh oh!

atuin-bot commented Oct 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

markovejnovic commented Oct 22, 2026 •

edited

Loading

greptile-apps Bot commented Oct 22, 2026 •

edited

Loading

atuin-bot commented Oct 22, 2026 •

edited

Loading