Repository navigation
chore: remove the benchmarks - #4511
Merged
Merged
Conversation
markovejnovic
marked this pull request as ready for review
October 22, 2026 00:24
Contributor
 [Low impact] The PR appears safe to merge; no actionable issues were found. SummaryRemoves benchmark targets,
Reviews (1) · Last reviewed commit: "chore: remove the benchmarks" · Reviewed by Greptile |
Member
Author
|
/merge |
Collaborator
|
Landed as 93bbf9c. GitHub shows this merged once it reaches main. |
Nothing has run the benchmarks since the CodSpeed workflow was removed in #3812. Buildkite lints and builds only the libraries, binaries and tests, so the benches compiled only when someone ran them by hand.
atuin-bot
force-pushed
the
chore/remove-benches
branch
from
October 22, 2026 00:43
6ddd910 to
93bbf9c
Compare
atuin-bot
pushed a commit
that referenced
this pull request
Oct 22, 2026
### Bug Fixes - *(ai)* Import IntoStaticStr from strum_macros, not strum ([#4480](#4480)) - *(ai)* Improve detection of git repositories ([#4450](#4450)) - *(client)* Resolve relative config paths beside config.toml, not the cwd ([#4479](#4479)) - *(config)* Don't print errors twice ([#4501](#4501)) - *(daemon)* Fetch the server's capabilities until a fetch succeeds - *(daemon)* Spare a stale pidfile's PID when evicting ([#4512](#4512)) - *(daemon)* Handle daemons not spawned by atuin ([#4516](#4516)) - *(output)* Keep quoted words together in output search ([#4502](#4502)) - *(packfile)* Load only the records inside a manifest's range - *(pty-proxy)* Standalone init with `atuin pty-proxy init` ([#4449](#4449)) - *(pty-proxy)* Wait for input on a non-blocking inherited stdin ([#4486](#4486)) - *(pty-proxy)* Don't re-exec shells running commands from a string or file ([#4414](#4414)) - *(search)* Don't panic when copying with no results ([#4426](#4426)) - *(server)* Let `ATUIN_*` environment variables override server.toml ([#4456](#4456)) - *(update)* Accept ATUIN_GITHUB_TOKEN ([#4262](#4262)) - Remove duplicated word in the no-history stats message ([#4451](#4451)) - Error printing in `?` handler ([#4448](#4448)) - Normalize relative gitdir paths in worktree resolution ([#4506](#4506)) - Upgrade regressions found in release QA ([#4519](#4519)) ### Documentation - Fix ctrl_n_shortcuts default value ([#4458](#4458)) - List all history list --format variables ([#4460](#4460)) - Fix the --reverse default for history list ([#4472](#4472)) - Mention December default in wrapped --year help ([#4476](#4476)) ### Features - *(common)* AbsPath and AbsPathBuf, Path and PathBuf checked to be absolute ([#4481](#4481)) - *(common)* Find a process's cgroup under cgroup v1 and v2 ([#4513](#4513)) - *(daemon)* Run the daemon as a launchd agent on macOS ([#4517](#4517)) - *(pty-proxy)* Window title follows child process ([#4447](#4447)) - *(secrets)* Keep HashiCorp tokens out of history ([#4445](#4445)) ### Miscellaneous Tasks - Give mono its own nixfmt step and scope atuin's to atuin/ - Say a /merge's landed commit gets CI on main - Rebuild the apt .deb cache for Ubuntu 24.04 ([#4504](#4504)) - Remove the benchmarks ([#4511](#4511)) ### Performance - *(common)* Compile the vendor regexes once ([#4485](#4485)) - *(common)* Drop the tree watcher's file-id cache ([#4492](#4492)) - *(common)* Release a line reader's buffer at the end of the file ([#4494](#4494)) - *(common)* Keep no tree watcher entry for a rejected file ([#4493](#4493)) - *(daemon)* Warm up only a resumed session's unanswered calls ([#4490](#4490)) - *(packfile)* Compress packs in one shot ([#4484](#4484)) ### Refactor - *(daemon)* Managed daemon service with multiple backends ([#4488](#4488)) - *(daemon)* Move daemon startup into the service module ([#4503](#4503)) - *(daemon)* Keep where the daemon listens behind service::address ([#4514](#4514)) - *(daemon)* Take up the daemon's socket in SocketHolder, not Backend ([#4515](#4515)) - *(deps)* Bump clap_complete_nushell from 4.6.0 to 4.6.2 ([#4473](#4473)) - *(deps)* Bump clap_complete from 4.6.9 to 4.6.11 ([#4396](#4396)) - *(deps)* Bump ratatui from 0.30.0 to 0.30.2 ([#4474](#4474)) - *(deps)* Bump certifi from 2025.11.12 to 2026.10.19 in /docs in the uv group across 1 directory ([#4500](#4500)) - *(pty-proxy)* Run on tokio with the parser on its own runtime ([#4482](#4482)) - *(pty-proxy)* Forward captures to the daemon on the proxy's runtime ([#4487](#4487)) - *(pty-proxy)* Rename the screen's parser to Emulator ([#4510](#4510)) - *(pty-proxy)* Migrate output parsing to vte ([#4518](#4518)) ### Testing - *(daemon)* Run the output index tests under rstest ([#4496](#4496))
1 task
codyps
added a commit
to codyps/atuin
that referenced
this pull request
Nov 8, 2026
Upstream removed every benchmark in atuinsh#4511 (nothing had run them since the CodSpeed workflow was dropped in atuinsh#3812), and rebasing onto v18.24.5 dropped this fork's benches along with the scaffolding they extended -- leaving the fuzzy-scoring work unmeasurable. Restore the fork-owned suite as a commit on top of the rebase: - atuin-client, divan `benchmarks` harness: fuzzy_scoring (optimized reorder_fuzzy vs the former allocating minspan baseline, with equivalence assertions between the two) and ranked_results (by-id rank restoration vs the clone-and-search baseline) - atuin-daemon: metadata bench comparing the inline SmallSet metadata with the former three-HashSet layout - atuin-search-bench: the crate is back (deterministic synthetic corpus, BENCH_DATA/BENCH_SCALES/BENCH_SEED configuration) with the end-to-end daemon_search bench and the index-construction loader bench Adaptations for 18.24.5, since the benches were written against 18.23.0: - SearchIndex::search is now async and takes &Sqlite to compile its filter; daemon_search completes each query on a shared current-thread runtime with an empty in-memory database (only SessionPreload filters consult it, and this bench uses Global and Directory) - all_paged lost its `unique` argument together with the grouped (deduplicated) pagination, so the grouped loader baseline is dropped; the owned-load baseline keeps visiting every row via the two-argument call and isolates the borrowed-row decoding change - std::env::var is now a disallowed method; read BENCH_* variables through atuin_common::env::var like the rest of the workspace - upstream-only benches (history, history_store, ordering, record, output_index, render_char and the shared benches/_util context) are not resurrected; only the suite this fork needs Run with: cargo bench -p atuin-client --bench benchmarks -- fuzzy_scoring cargo bench -p atuin-daemon --bench metadata cargo bench -p atuin-search-bench # loader + daemon_search Validation: cargo bench --no-run and clippy --benches -D warnings pass for all three packages under the pinned 1.98.0 toolchain; each bench was smoke-run (allocation counters reporting); the full atuin-client and atuin-daemon test suites still pass (1086 + 599 tests) with the updated Cargo.lock, which only gains divan's dependency tree and the atuin-search-bench package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nothing has run the benchmarks since the CodSpeed workflow was removed in #3812. Buildkite lints and builds only the libraries, binaries and tests, so the benches compiled only when someone ran them by hand.