Skip to content

chore: prefer cfg!() over #[cfg()] in AGENTS.md - #4676

Merged
atuin-bot merged 1 commit into
mainfrom
taylordotfish/agents-md-cfg
Nov 6, 2026
Merged

atuin-bot merged 1 commit into
mainfrom
taylordotfish/agents-md-cfg

Conversation

@taylordotfish

Copy link
Copy Markdown
Member

No description provided.

@greptile-apps

greptile-apps Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] This documentation-only change appears safe to merge.

Summary

Updates AGENTS.md to prefer if cfg!() when conditional compilation is unnecessary.

  • Repository guidance reserves #[cfg()] for code that needs conditional compilation.

Reviews (1) Β· Last reviewed commit: "chore: prefer `cfg!()` over `#[cfg()]` i..." Β· Reviewed by Greptile

@taylordotfish

Copy link
Copy Markdown
Member Author

/merge yolo

@taylordotfish

Copy link
Copy Markdown
Member Author

/merge yolo

@atuin-bot

atuin-bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Collaborator

Landed as 307b522 without CI. GitHub shows this merged once it reaches main.

@atuin-bot
atuin-bot force-pushed the taylordotfish/agents-md-cfg branch from 7f42f5a to 307b522 Compare November 6, 2026 23:33
@atuin-bot
atuin-bot merged commit 307b522 into main Nov 6, 2026
3 checks passed
@atuin-bot
atuin-bot deleted the taylordotfish/agents-md-cfg branch November 6, 2026 23:33
atuin-bot pushed a commit that referenced this pull request Nov 10, 2026
Release 18.24.6


### Bug Fixes

- *(api)* Move to the fixed cowboy, cowlib and grpc_server
- *(copilot)* Register the hook as exec/args so PowerShell can run it ([#4634](#4634))
- *(daemon)* Close inherited fds before autostarting, fixing indefinite pty-proxy hang on shell exit ([#4668](#4668))
- *(daemon)* Don't manage the socket with launchd ([#4669](#4669))
- *(deps)* Bump rmcp for three advisories, and hold the SQLite one until sqlx allows the fix ([#4690](#4690))
- *(setup)* Don't warn about uninstalled harnesses ([#4680](#4680))
- *(threads)* Capture Claude Code shell edits' diffs, and keep the patch of a write that names atuin key ([#4670](#4670))
- *(threads)* Fix mislabeling of omp child transcripts as Pi ([#4694](#4694))
- Include workaround for buggy VTE versions ([#4679](#4679))


### Features

- *(search)* Support jj workspace filters ([#4457](#4457))
- *(setup)* Sharper capture and search labels, and give sync its own section ([#4659](#4659))


### Miscellaneous Tasks

- Add "Writing style" section to AGENTS.md ([#4675](#4675))
- Prefer `cfg!()` over `#[cfg()]` in AGENTS.md ([#4676](#4676))
- Prefer `let _ = ...` over `_ = ...` in AGENTS.md ([#4678](#4678))


### Refactor

- *(deps)* Bump hyper-util from 0.1.20 to 0.1.21 ([#4626](#4626))
- *(deps)* Bump unicode-normalization from 0.1.25 to 0.1.26 ([#4686](#4686))


### Build

- *(atuin)* Make octavo a default feature, still off at runtime ([#4693](#4693))
- *(release)* Compile octavo into release artifacts, still off by default ([#4671](#4671))
renovate Bot added a commit to sdwilsh/ansible-playbooks that referenced this pull request Nov 10, 2026
##### [\`18.24.6\`](https://github.com/atuinsh/atuin/blob/HEAD/CHANGELOG.md#18246)

##### Bug Fixes

- *(api)* Move to the fixed cowboy, cowlib and grpc_server
- *(copilot)* Register the hook as exec/args so PowerShell can run it ([#4634](atuinsh/atuin#4634))
- *(daemon)* Close inherited fds before autostarting, fixing indefinite pty-proxy hang on shell exit ([#4668](atuinsh/atuin#4668))
- *(daemon)* Don't manage the socket with launchd ([#4669](atuinsh/atuin#4669))
- *(deps)* Bump rmcp for three advisories, and hold the SQLite one until sqlx allows the fix ([#4690](atuinsh/atuin#4690))
- *(setup)* Don't warn about uninstalled harnesses ([#4680](atuinsh/atuin#4680))
- *(threads)* Capture Claude Code shell edits' diffs, and keep the patch of a write that names atuin key ([#4670](atuinsh/atuin#4670))
- *(threads)* Fix mislabeling of omp child transcripts as Pi ([#4694](atuinsh/atuin#4694))
- Include workaround for buggy VTE versions ([#4679](atuinsh/atuin#4679))

##### Features

- *(search)* Support jj workspace filters ([#4457](atuinsh/atuin#4457))
- *(setup)* Sharper capture and search labels, and give sync its own section ([#4659](atuinsh/atuin#4659))

##### Miscellaneous Tasks

- Add "Writing style" section to AGENTS.md ([#4675](atuinsh/atuin#4675))
- Prefer `cfg!()` over `#[cfg()]` in AGENTS.md ([#4676](atuinsh/atuin#4676))
- Prefer `let _ = ...` over `_ = ...` in AGENTS.md ([#4678](atuinsh/atuin#4678))

##### Refactor

- *(deps)* Bump hyper-util from 0.1.20 to 0.1.21 ([#4626](atuinsh/atuin#4626))
- *(deps)* Bump unicode-normalization from 0.1.25 to 0.1.26 ([#4686](atuinsh/atuin#4686))

##### Build

- *(atuin)* Make octavo a default feature, still off at runtime ([#4693](atuinsh/atuin#4693))
- *(release)* Compile octavo into release artifacts, still off by default ([#4671](atuinsh/atuin#4671))
renovate Bot added a commit to sdwilsh/ansible-playbooks that referenced this pull request Nov 10, 2026
##### [\`18.24.6\`](https://github.com/atuinsh/atuin/blob/HEAD/CHANGELOG.md#18246)

##### Bug Fixes

- *(api)* Move to the fixed cowboy, cowlib and grpc_server
- *(copilot)* Register the hook as exec/args so PowerShell can run it ([#4634](atuinsh/atuin#4634))
- *(daemon)* Close inherited fds before autostarting, fixing indefinite pty-proxy hang on shell exit ([#4668](atuinsh/atuin#4668))
- *(daemon)* Don't manage the socket with launchd ([#4669](atuinsh/atuin#4669))
- *(deps)* Bump rmcp for three advisories, and hold the SQLite one until sqlx allows the fix ([#4690](atuinsh/atuin#4690))
- *(setup)* Don't warn about uninstalled harnesses ([#4680](atuinsh/atuin#4680))
- *(threads)* Capture Claude Code shell edits' diffs, and keep the patch of a write that names atuin key ([#4670](atuinsh/atuin#4670))
- *(threads)* Fix mislabeling of omp child transcripts as Pi ([#4694](atuinsh/atuin#4694))
- Include workaround for buggy VTE versions ([#4679](atuinsh/atuin#4679))

##### Features

- *(search)* Support jj workspace filters ([#4457](atuinsh/atuin#4457))
- *(setup)* Sharper capture and search labels, and give sync its own section ([#4659](atuinsh/atuin#4659))

##### Miscellaneous Tasks

- Add "Writing style" section to AGENTS.md ([#4675](atuinsh/atuin#4675))
- Prefer `cfg!()` over `#[cfg()]` in AGENTS.md ([#4676](atuinsh/atuin#4676))
- Prefer `let _ = ...` over `_ = ...` in AGENTS.md ([#4678](atuinsh/atuin#4678))

##### Refactor

- *(deps)* Bump hyper-util from 0.1.20 to 0.1.21 ([#4626](atuinsh/atuin#4626))
- *(deps)* Bump unicode-normalization from 0.1.25 to 0.1.26 ([#4686](atuinsh/atuin#4686))

##### Build

- *(atuin)* Make octavo a default feature, still off at runtime ([#4693](atuinsh/atuin#4693))
- *(release)* Compile octavo into release artifacts, still off by default ([#4671](atuinsh/atuin#4671))
renovate Bot added a commit to sdwilsh/ansible-playbooks that referenced this pull request Nov 10, 2026
##### [\`18.24.6\`](https://github.com/atuinsh/atuin/blob/HEAD/CHANGELOG.md#18246)

##### Bug Fixes

- *(api)* Move to the fixed cowboy, cowlib and grpc_server
- *(copilot)* Register the hook as exec/args so PowerShell can run it ([#4634](atuinsh/atuin#4634))
- *(daemon)* Close inherited fds before autostarting, fixing indefinite pty-proxy hang on shell exit ([#4668](atuinsh/atuin#4668))
- *(daemon)* Don't manage the socket with launchd ([#4669](atuinsh/atuin#4669))
- *(deps)* Bump rmcp for three advisories, and hold the SQLite one until sqlx allows the fix ([#4690](atuinsh/atuin#4690))
- *(setup)* Don't warn about uninstalled harnesses ([#4680](atuinsh/atuin#4680))
- *(threads)* Capture Claude Code shell edits' diffs, and keep the patch of a write that names atuin key ([#4670](atuinsh/atuin#4670))
- *(threads)* Fix mislabeling of omp child transcripts as Pi ([#4694](atuinsh/atuin#4694))
- Include workaround for buggy VTE versions ([#4679](atuinsh/atuin#4679))

##### Features

- *(search)* Support jj workspace filters ([#4457](atuinsh/atuin#4457))
- *(setup)* Sharper capture and search labels, and give sync its own section ([#4659](atuinsh/atuin#4659))

##### Miscellaneous Tasks

- Add "Writing style" section to AGENTS.md ([#4675](atuinsh/atuin#4675))
- Prefer `cfg!()` over `#[cfg()]` in AGENTS.md ([#4676](atuinsh/atuin#4676))
- Prefer `let _ = ...` over `_ = ...` in AGENTS.md ([#4678](atuinsh/atuin#4678))

##### Refactor

- *(deps)* Bump hyper-util from 0.1.20 to 0.1.21 ([#4626](atuinsh/atuin#4626))
- *(deps)* Bump unicode-normalization from 0.1.25 to 0.1.26 ([#4686](atuinsh/atuin#4686))

##### Build

- *(atuin)* Make octavo a default feature, still off at runtime ([#4693](atuinsh/atuin#4693))
- *(release)* Compile octavo into release artifacts, still off by default ([#4671](atuinsh/atuin#4671))
renovate Bot added a commit to sdwilsh/ansible-playbooks that referenced this pull request Nov 10, 2026
##### [\`18.24.6\`](https://github.com/atuinsh/atuin/blob/HEAD/CHANGELOG.md#18246)

##### Bug Fixes

- *(api)* Move to the fixed cowboy, cowlib and grpc_server
- *(copilot)* Register the hook as exec/args so PowerShell can run it ([#4634](atuinsh/atuin#4634))
- *(daemon)* Close inherited fds before autostarting, fixing indefinite pty-proxy hang on shell exit ([#4668](atuinsh/atuin#4668))
- *(daemon)* Don't manage the socket with launchd ([#4669](atuinsh/atuin#4669))
- *(deps)* Bump rmcp for three advisories, and hold the SQLite one until sqlx allows the fix ([#4690](atuinsh/atuin#4690))
- *(setup)* Don't warn about uninstalled harnesses ([#4680](atuinsh/atuin#4680))
- *(threads)* Capture Claude Code shell edits' diffs, and keep the patch of a write that names atuin key ([#4670](atuinsh/atuin#4670))
- *(threads)* Fix mislabeling of omp child transcripts as Pi ([#4694](atuinsh/atuin#4694))
- Include workaround for buggy VTE versions ([#4679](atuinsh/atuin#4679))

##### Features

- *(search)* Support jj workspace filters ([#4457](atuinsh/atuin#4457))
- *(setup)* Sharper capture and search labels, and give sync its own section ([#4659](atuinsh/atuin#4659))

##### Miscellaneous Tasks

- Add "Writing style" section to AGENTS.md ([#4675](atuinsh/atuin#4675))
- Prefer `cfg!()` over `#[cfg()]` in AGENTS.md ([#4676](atuinsh/atuin#4676))
- Prefer `let _ = ...` over `_ = ...` in AGENTS.md ([#4678](atuinsh/atuin#4678))

##### Refactor

- *(deps)* Bump hyper-util from 0.1.20 to 0.1.21 ([#4626](atuinsh/atuin#4626))
- *(deps)* Bump unicode-normalization from 0.1.25 to 0.1.26 ([#4686](atuinsh/atuin#4686))

##### Build

- *(atuin)* Make octavo a default feature, still off at runtime ([#4693](atuinsh/atuin#4693))
- *(release)* Compile octavo into release artifacts, still off by default ([#4671](atuinsh/atuin#4671))
eleboucher pushed a commit to eleboucher/homelab that referenced this pull request Nov 10, 2026
…) (#2584)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [ghcr.io/atuinsh/atuin](https://github.com/atuinsh/atuin) | patch | `18.24.5` β†’ `18.24.6` |

---

### Release Notes

<details>
<summary>atuinsh/atuin (ghcr.io/atuinsh/atuin)</summary>

### [`v18.24.6`](https://github.com/atuinsh/atuin/blob/HEAD/CHANGELOG.md#18246)

[Compare Source](atuinsh/atuin@v18.24.5...v18.24.6)

##### Bug Fixes

- *(api)* Move to the fixed cowboy, cowlib and grpc_server
- *(copilot)* Register the hook as exec/args so PowerShell can run it ([#&#8203;4634](atuinsh/atuin#4634))
- *(daemon)* Close inherited fds before autostarting, fixing indefinite pty-proxy hang on shell exit ([#&#8203;4668](atuinsh/atuin#4668))
- *(daemon)* Don't manage the socket with launchd ([#&#8203;4669](atuinsh/atuin#4669))
- *(deps)* Bump rmcp for three advisories, and hold the SQLite one until sqlx allows the fix ([#&#8203;4690](atuinsh/atuin#4690))
- *(setup)* Don't warn about uninstalled harnesses ([#&#8203;4680](atuinsh/atuin#4680))
- *(threads)* Capture Claude Code shell edits' diffs, and keep the patch of a write that names atuin key ([#&#8203;4670](atuinsh/atuin#4670))
- *(threads)* Fix mislabeling of omp child transcripts as Pi ([#&#8203;4694](atuinsh/atuin#4694))
- Include workaround for buggy VTE versions ([#&#8203;4679](atuinsh/atuin#4679))

##### Features

- *(search)* Support jj workspace filters ([#&#8203;4457](atuinsh/atuin#4457))
- *(setup)* Sharper capture and search labels, and give sync its own section ([#&#8203;4659](atuinsh/atuin#4659))

##### Miscellaneous Tasks

- Add "Writing style" section to AGENTS.md ([#&#8203;4675](atuinsh/atuin#4675))
- Prefer `cfg!()` over `#[cfg()]` in AGENTS.md ([#&#8203;4676](atuinsh/atuin#4676))
- Prefer `let _ = ...` over `_ = ...` in AGENTS.md ([#&#8203;4678](atuinsh/atuin#4678))

##### Refactor

- *(deps)* Bump hyper-util from 0.1.20 to 0.1.21 ([#&#8203;4626](atuinsh/atuin#4626))
- *(deps)* Bump unicode-normalization from 0.1.25 to 0.1.26 ([#&#8203;4686](atuinsh/atuin#4686))

##### Build

- *(atuin)* Make octavo a default feature, still off at runtime ([#&#8203;4693](atuinsh/atuin#4693))
- *(release)* Compile octavo into release artifacts, still off by default ([#&#8203;4671](atuinsh/atuin#4671))

</details>

---

### Configuration

πŸ“… **Schedule**: (UTC)

- Branch creation
  - At any time (no schedule defined)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

β™» **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

πŸ”• **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4yMjIuNSIsInVwZGF0ZWRJblZlciI6IjQ0LjIyMi41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Reviewed-on: https://git.erwanleboucher.dev/eleboucher/homelab/pulls/2584
doonga pushed a commit to greyrock-labs/home-ops that referenced this pull request Nov 10, 2026
…) (#718)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [ghcr.io/atuinsh/atuin](https://github.com/atuinsh/atuin) | patch | `18.24.5` β†’ `18.24.6` |

---

### Release Notes

<details>
<summary>atuinsh/atuin (ghcr.io/atuinsh/atuin)</summary>

### [`v18.24.6`](https://github.com/atuinsh/atuin/blob/HEAD/CHANGELOG.md#18246)

[Compare Source](atuinsh/atuin@v18.24.5...v18.24.6)

##### Bug Fixes

- *(api)* Move to the fixed cowboy, cowlib and grpc_server
- *(copilot)* Register the hook as exec/args so PowerShell can run it ([#&#8203;4634](atuinsh/atuin#4634))
- *(daemon)* Close inherited fds before autostarting, fixing indefinite pty-proxy hang on shell exit ([#&#8203;4668](atuinsh/atuin#4668))
- *(daemon)* Don't manage the socket with launchd ([#&#8203;4669](atuinsh/atuin#4669))
- *(deps)* Bump rmcp for three advisories, and hold the SQLite one until sqlx allows the fix ([#&#8203;4690](atuinsh/atuin#4690))
- *(setup)* Don't warn about uninstalled harnesses ([#&#8203;4680](atuinsh/atuin#4680))
- *(threads)* Capture Claude Code shell edits' diffs, and keep the patch of a write that names atuin key ([#&#8203;4670](atuinsh/atuin#4670))
- *(threads)* Fix mislabeling of omp child transcripts as Pi ([#&#8203;4694](atuinsh/atuin#4694))
- Include workaround for buggy VTE versions ([#&#8203;4679](atuinsh/atuin#4679))

##### Features

- *(search)* Support jj workspace filters ([#&#8203;4457](atuinsh/atuin#4457))
- *(setup)* Sharper capture and search labels, and give sync its own section ([#&#8203;4659](atuinsh/atuin#4659))

##### Miscellaneous Tasks

- Add "Writing style" section to AGENTS.md ([#&#8203;4675](atuinsh/atuin#4675))
- Prefer `cfg!()` over `#[cfg()]` in AGENTS.md ([#&#8203;4676](atuinsh/atuin#4676))
- Prefer `let _ = ...` over `_ = ...` in AGENTS.md ([#&#8203;4678](atuinsh/atuin#4678))

##### Refactor

- *(deps)* Bump hyper-util from 0.1.20 to 0.1.21 ([#&#8203;4626](atuinsh/atuin#4626))
- *(deps)* Bump unicode-normalization from 0.1.25 to 0.1.26 ([#&#8203;4686](atuinsh/atuin#4686))

##### Build

- *(atuin)* Make octavo a default feature, still off at runtime ([#&#8203;4693](atuinsh/atuin#4693))
- *(release)* Compile octavo into release artifacts, still off by default ([#&#8203;4671](atuinsh/atuin#4671))

</details>

---

### Configuration

πŸ“… **Schedule**: (in timezone America/New_York)

- Branch creation
  - At any time (no schedule defined)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

β™» **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

πŸ”• **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4yMjIuNSIsInVwZGF0ZWRJblZlciI6IjQ0LjIyMi41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9jb250YWluZXIiLCJ0eXBlL3BhdGNoIl19-->

Reviewed-on: https://git.greyrock.io/todd/home-ops/pulls/718
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants