Repository navigation
fix: include workaround for buggy VTE versions - #4679
Merged
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
 [Medium impact] The PR appears safe to merge. SummaryAdds a Bash hook workaround for affected VTE versions.
No actionable issues found. Reviews (1) · Last reviewed commit: "fix: include workaround for buggy VTE ve..." · Reviewed by Greptile |
Member
Author
|
/merge |
Collaborator
|
Landed as af0d453. GitHub shows this merged once it reaches main. |
Old versions of VTE have [a bug](https://gitlab.gnome.org/GNOME/vte/-/work_items/2951) that breaks bash-preexec on Bash 5.3 and later. See #3456 for more information. Even though this is an issue in VTE rather than Atuin, bundling a workaround will improve the experience for users stuck on older versions of VTE. This PR patches bash-preexec to revert to using the `DEBUG`-based method of hooking into Bash instead of the newer `PS0` method, which is what the VTE issue adversely affects. This is only on terminals that use the VTE integration.
atuin-bot
force-pushed
the
taylordotfish/old-vte-workaround
branch
from
November 7, 2026 04:17
6d21ccc to
af0d453
Compare
1 task done
atuin-bot
pushed a commit
that referenced
this pull request
Nov 10, 2026
Release 18.24.6 ### Bug Fixes - *(api)* Move to the fixed cowboy, cowlib and grpc_server - *(copilot)* Register the hook as exec/args so PowerShell can run it ([#4634](#4634)) - *(daemon)* Close inherited fds before autostarting, fixing indefinite pty-proxy hang on shell exit ([#4668](#4668)) - *(daemon)* Don't manage the socket with launchd ([#4669](#4669)) - *(deps)* Bump rmcp for three advisories, and hold the SQLite one until sqlx allows the fix ([#4690](#4690)) - *(setup)* Don't warn about uninstalled harnesses ([#4680](#4680)) - *(threads)* Capture Claude Code shell edits' diffs, and keep the patch of a write that names atuin key ([#4670](#4670)) - *(threads)* Fix mislabeling of omp child transcripts as Pi ([#4694](#4694)) - Include workaround for buggy VTE versions ([#4679](#4679)) ### Features - *(search)* Support jj workspace filters ([#4457](#4457)) - *(setup)* Sharper capture and search labels, and give sync its own section ([#4659](#4659)) ### Miscellaneous Tasks - Add "Writing style" section to AGENTS.md ([#4675](#4675)) - Prefer `cfg!()` over `#[cfg()]` in AGENTS.md ([#4676](#4676)) - Prefer `let _ = ...` over `_ = ...` in AGENTS.md ([#4678](#4678)) ### Refactor - *(deps)* Bump hyper-util from 0.1.20 to 0.1.21 ([#4626](#4626)) - *(deps)* Bump unicode-normalization from 0.1.25 to 0.1.26 ([#4686](#4686)) ### Build - *(atuin)* Make octavo a default feature, still off at runtime ([#4693](#4693)) - *(release)* Compile octavo into release artifacts, still off by default ([#4671](#4671))
renovate Bot
added a commit
to sdwilsh/ansible-playbooks
that referenced
this pull request
Nov 10, 2026
##### [\`18.24.6\`](https://github.com/atuinsh/atuin/blob/HEAD/CHANGELOG.md#18246) ##### Bug Fixes - *(api)* Move to the fixed cowboy, cowlib and grpc_server - *(copilot)* Register the hook as exec/args so PowerShell can run it ([#4634](atuinsh/atuin#4634)) - *(daemon)* Close inherited fds before autostarting, fixing indefinite pty-proxy hang on shell exit ([#4668](atuinsh/atuin#4668)) - *(daemon)* Don't manage the socket with launchd ([#4669](atuinsh/atuin#4669)) - *(deps)* Bump rmcp for three advisories, and hold the SQLite one until sqlx allows the fix ([#4690](atuinsh/atuin#4690)) - *(setup)* Don't warn about uninstalled harnesses ([#4680](atuinsh/atuin#4680)) - *(threads)* Capture Claude Code shell edits' diffs, and keep the patch of a write that names atuin key ([#4670](atuinsh/atuin#4670)) - *(threads)* Fix mislabeling of omp child transcripts as Pi ([#4694](atuinsh/atuin#4694)) - Include workaround for buggy VTE versions ([#4679](atuinsh/atuin#4679)) ##### Features - *(search)* Support jj workspace filters ([#4457](atuinsh/atuin#4457)) - *(setup)* Sharper capture and search labels, and give sync its own section ([#4659](atuinsh/atuin#4659)) ##### Miscellaneous Tasks - Add "Writing style" section to AGENTS.md ([#4675](atuinsh/atuin#4675)) - Prefer `cfg!()` over `#[cfg()]` in AGENTS.md ([#4676](atuinsh/atuin#4676)) - Prefer `let _ = ...` over `_ = ...` in AGENTS.md ([#4678](atuinsh/atuin#4678)) ##### Refactor - *(deps)* Bump hyper-util from 0.1.20 to 0.1.21 ([#4626](atuinsh/atuin#4626)) - *(deps)* Bump unicode-normalization from 0.1.25 to 0.1.26 ([#4686](atuinsh/atuin#4686)) ##### Build - *(atuin)* Make octavo a default feature, still off at runtime ([#4693](atuinsh/atuin#4693)) - *(release)* Compile octavo into release artifacts, still off by default ([#4671](atuinsh/atuin#4671))
renovate Bot
added a commit
to sdwilsh/ansible-playbooks
that referenced
this pull request
Nov 10, 2026
##### [\`18.24.6\`](https://github.com/atuinsh/atuin/blob/HEAD/CHANGELOG.md#18246) ##### Bug Fixes - *(api)* Move to the fixed cowboy, cowlib and grpc_server - *(copilot)* Register the hook as exec/args so PowerShell can run it ([#4634](atuinsh/atuin#4634)) - *(daemon)* Close inherited fds before autostarting, fixing indefinite pty-proxy hang on shell exit ([#4668](atuinsh/atuin#4668)) - *(daemon)* Don't manage the socket with launchd ([#4669](atuinsh/atuin#4669)) - *(deps)* Bump rmcp for three advisories, and hold the SQLite one until sqlx allows the fix ([#4690](atuinsh/atuin#4690)) - *(setup)* Don't warn about uninstalled harnesses ([#4680](atuinsh/atuin#4680)) - *(threads)* Capture Claude Code shell edits' diffs, and keep the patch of a write that names atuin key ([#4670](atuinsh/atuin#4670)) - *(threads)* Fix mislabeling of omp child transcripts as Pi ([#4694](atuinsh/atuin#4694)) - Include workaround for buggy VTE versions ([#4679](atuinsh/atuin#4679)) ##### Features - *(search)* Support jj workspace filters ([#4457](atuinsh/atuin#4457)) - *(setup)* Sharper capture and search labels, and give sync its own section ([#4659](atuinsh/atuin#4659)) ##### Miscellaneous Tasks - Add "Writing style" section to AGENTS.md ([#4675](atuinsh/atuin#4675)) - Prefer `cfg!()` over `#[cfg()]` in AGENTS.md ([#4676](atuinsh/atuin#4676)) - Prefer `let _ = ...` over `_ = ...` in AGENTS.md ([#4678](atuinsh/atuin#4678)) ##### Refactor - *(deps)* Bump hyper-util from 0.1.20 to 0.1.21 ([#4626](atuinsh/atuin#4626)) - *(deps)* Bump unicode-normalization from 0.1.25 to 0.1.26 ([#4686](atuinsh/atuin#4686)) ##### Build - *(atuin)* Make octavo a default feature, still off at runtime ([#4693](atuinsh/atuin#4693)) - *(release)* Compile octavo into release artifacts, still off by default ([#4671](atuinsh/atuin#4671))
renovate Bot
added a commit
to sdwilsh/ansible-playbooks
that referenced
this pull request
Nov 10, 2026
##### [\`18.24.6\`](https://github.com/atuinsh/atuin/blob/HEAD/CHANGELOG.md#18246) ##### Bug Fixes - *(api)* Move to the fixed cowboy, cowlib and grpc_server - *(copilot)* Register the hook as exec/args so PowerShell can run it ([#4634](atuinsh/atuin#4634)) - *(daemon)* Close inherited fds before autostarting, fixing indefinite pty-proxy hang on shell exit ([#4668](atuinsh/atuin#4668)) - *(daemon)* Don't manage the socket with launchd ([#4669](atuinsh/atuin#4669)) - *(deps)* Bump rmcp for three advisories, and hold the SQLite one until sqlx allows the fix ([#4690](atuinsh/atuin#4690)) - *(setup)* Don't warn about uninstalled harnesses ([#4680](atuinsh/atuin#4680)) - *(threads)* Capture Claude Code shell edits' diffs, and keep the patch of a write that names atuin key ([#4670](atuinsh/atuin#4670)) - *(threads)* Fix mislabeling of omp child transcripts as Pi ([#4694](atuinsh/atuin#4694)) - Include workaround for buggy VTE versions ([#4679](atuinsh/atuin#4679)) ##### Features - *(search)* Support jj workspace filters ([#4457](atuinsh/atuin#4457)) - *(setup)* Sharper capture and search labels, and give sync its own section ([#4659](atuinsh/atuin#4659)) ##### Miscellaneous Tasks - Add "Writing style" section to AGENTS.md ([#4675](atuinsh/atuin#4675)) - Prefer `cfg!()` over `#[cfg()]` in AGENTS.md ([#4676](atuinsh/atuin#4676)) - Prefer `let _ = ...` over `_ = ...` in AGENTS.md ([#4678](atuinsh/atuin#4678)) ##### Refactor - *(deps)* Bump hyper-util from 0.1.20 to 0.1.21 ([#4626](atuinsh/atuin#4626)) - *(deps)* Bump unicode-normalization from 0.1.25 to 0.1.26 ([#4686](atuinsh/atuin#4686)) ##### Build - *(atuin)* Make octavo a default feature, still off at runtime ([#4693](atuinsh/atuin#4693)) - *(release)* Compile octavo into release artifacts, still off by default ([#4671](atuinsh/atuin#4671))
renovate Bot
added a commit
to sdwilsh/ansible-playbooks
that referenced
this pull request
Nov 10, 2026
##### [\`18.24.6\`](https://github.com/atuinsh/atuin/blob/HEAD/CHANGELOG.md#18246) ##### Bug Fixes - *(api)* Move to the fixed cowboy, cowlib and grpc_server - *(copilot)* Register the hook as exec/args so PowerShell can run it ([#4634](atuinsh/atuin#4634)) - *(daemon)* Close inherited fds before autostarting, fixing indefinite pty-proxy hang on shell exit ([#4668](atuinsh/atuin#4668)) - *(daemon)* Don't manage the socket with launchd ([#4669](atuinsh/atuin#4669)) - *(deps)* Bump rmcp for three advisories, and hold the SQLite one until sqlx allows the fix ([#4690](atuinsh/atuin#4690)) - *(setup)* Don't warn about uninstalled harnesses ([#4680](atuinsh/atuin#4680)) - *(threads)* Capture Claude Code shell edits' diffs, and keep the patch of a write that names atuin key ([#4670](atuinsh/atuin#4670)) - *(threads)* Fix mislabeling of omp child transcripts as Pi ([#4694](atuinsh/atuin#4694)) - Include workaround for buggy VTE versions ([#4679](atuinsh/atuin#4679)) ##### Features - *(search)* Support jj workspace filters ([#4457](atuinsh/atuin#4457)) - *(setup)* Sharper capture and search labels, and give sync its own section ([#4659](atuinsh/atuin#4659)) ##### Miscellaneous Tasks - Add "Writing style" section to AGENTS.md ([#4675](atuinsh/atuin#4675)) - Prefer `cfg!()` over `#[cfg()]` in AGENTS.md ([#4676](atuinsh/atuin#4676)) - Prefer `let _ = ...` over `_ = ...` in AGENTS.md ([#4678](atuinsh/atuin#4678)) ##### Refactor - *(deps)* Bump hyper-util from 0.1.20 to 0.1.21 ([#4626](atuinsh/atuin#4626)) - *(deps)* Bump unicode-normalization from 0.1.25 to 0.1.26 ([#4686](atuinsh/atuin#4686)) ##### Build - *(atuin)* Make octavo a default feature, still off at runtime ([#4693](atuinsh/atuin#4693)) - *(release)* Compile octavo into release artifacts, still off by default ([#4671](atuinsh/atuin#4671))
eleboucher
pushed a commit
to eleboucher/homelab
that referenced
this pull request
Nov 10, 2026
…) (#2584) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/atuinsh/atuin](https://github.com/atuinsh/atuin) | patch | `18.24.5` → `18.24.6` | --- ### Release Notes <details> <summary>atuinsh/atuin (ghcr.io/atuinsh/atuin)</summary> ### [`v18.24.6`](https://github.com/atuinsh/atuin/blob/HEAD/CHANGELOG.md#18246) [Compare Source](atuinsh/atuin@v18.24.5...v18.24.6) ##### Bug Fixes - *(api)* Move to the fixed cowboy, cowlib and grpc_server - *(copilot)* Register the hook as exec/args so PowerShell can run it ([#​4634](atuinsh/atuin#4634)) - *(daemon)* Close inherited fds before autostarting, fixing indefinite pty-proxy hang on shell exit ([#​4668](atuinsh/atuin#4668)) - *(daemon)* Don't manage the socket with launchd ([#​4669](atuinsh/atuin#4669)) - *(deps)* Bump rmcp for three advisories, and hold the SQLite one until sqlx allows the fix ([#​4690](atuinsh/atuin#4690)) - *(setup)* Don't warn about uninstalled harnesses ([#​4680](atuinsh/atuin#4680)) - *(threads)* Capture Claude Code shell edits' diffs, and keep the patch of a write that names atuin key ([#​4670](atuinsh/atuin#4670)) - *(threads)* Fix mislabeling of omp child transcripts as Pi ([#​4694](atuinsh/atuin#4694)) - Include workaround for buggy VTE versions ([#​4679](atuinsh/atuin#4679)) ##### Features - *(search)* Support jj workspace filters ([#​4457](atuinsh/atuin#4457)) - *(setup)* Sharper capture and search labels, and give sync its own section ([#​4659](atuinsh/atuin#4659)) ##### Miscellaneous Tasks - Add "Writing style" section to AGENTS.md ([#​4675](atuinsh/atuin#4675)) - Prefer `cfg!()` over `#[cfg()]` in AGENTS.md ([#​4676](atuinsh/atuin#4676)) - Prefer `let _ = ...` over `_ = ...` in AGENTS.md ([#​4678](atuinsh/atuin#4678)) ##### Refactor - *(deps)* Bump hyper-util from 0.1.20 to 0.1.21 ([#​4626](atuinsh/atuin#4626)) - *(deps)* Bump unicode-normalization from 0.1.25 to 0.1.26 ([#​4686](atuinsh/atuin#4686)) ##### Build - *(atuin)* Make octavo a default feature, still off at runtime ([#​4693](atuinsh/atuin#4693)) - *(release)* Compile octavo into release artifacts, still off by default ([#​4671](atuinsh/atuin#4671)) </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4yMjIuNSIsInVwZGF0ZWRJblZlciI6IjQ0LjIyMi41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Reviewed-on: https://git.erwanleboucher.dev/eleboucher/homelab/pulls/2584
doonga
pushed a commit
to greyrock-labs/home-ops
that referenced
this pull request
Nov 10, 2026
…) (#718) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/atuinsh/atuin](https://github.com/atuinsh/atuin) | patch | `18.24.5` → `18.24.6` | --- ### Release Notes <details> <summary>atuinsh/atuin (ghcr.io/atuinsh/atuin)</summary> ### [`v18.24.6`](https://github.com/atuinsh/atuin/blob/HEAD/CHANGELOG.md#18246) [Compare Source](atuinsh/atuin@v18.24.5...v18.24.6) ##### Bug Fixes - *(api)* Move to the fixed cowboy, cowlib and grpc_server - *(copilot)* Register the hook as exec/args so PowerShell can run it ([#​4634](atuinsh/atuin#4634)) - *(daemon)* Close inherited fds before autostarting, fixing indefinite pty-proxy hang on shell exit ([#​4668](atuinsh/atuin#4668)) - *(daemon)* Don't manage the socket with launchd ([#​4669](atuinsh/atuin#4669)) - *(deps)* Bump rmcp for three advisories, and hold the SQLite one until sqlx allows the fix ([#​4690](atuinsh/atuin#4690)) - *(setup)* Don't warn about uninstalled harnesses ([#​4680](atuinsh/atuin#4680)) - *(threads)* Capture Claude Code shell edits' diffs, and keep the patch of a write that names atuin key ([#​4670](atuinsh/atuin#4670)) - *(threads)* Fix mislabeling of omp child transcripts as Pi ([#​4694](atuinsh/atuin#4694)) - Include workaround for buggy VTE versions ([#​4679](atuinsh/atuin#4679)) ##### Features - *(search)* Support jj workspace filters ([#​4457](atuinsh/atuin#4457)) - *(setup)* Sharper capture and search labels, and give sync its own section ([#​4659](atuinsh/atuin#4659)) ##### Miscellaneous Tasks - Add "Writing style" section to AGENTS.md ([#​4675](atuinsh/atuin#4675)) - Prefer `cfg!()` over `#[cfg()]` in AGENTS.md ([#​4676](atuinsh/atuin#4676)) - Prefer `let _ = ...` over `_ = ...` in AGENTS.md ([#​4678](atuinsh/atuin#4678)) ##### Refactor - *(deps)* Bump hyper-util from 0.1.20 to 0.1.21 ([#​4626](atuinsh/atuin#4626)) - *(deps)* Bump unicode-normalization from 0.1.25 to 0.1.26 ([#​4686](atuinsh/atuin#4686)) ##### Build - *(atuin)* Make octavo a default feature, still off at runtime ([#​4693](atuinsh/atuin#4693)) - *(release)* Compile octavo into release artifacts, still off by default ([#​4671](atuinsh/atuin#4671)) </details> --- ### Configuration 📅 **Schedule**: (in timezone America/New_York) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4yMjIuNSIsInVwZGF0ZWRJblZlciI6IjQ0LjIyMi41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9jb250YWluZXIiLCJ0eXBlL3BhdGNoIl19--> Reviewed-on: https://git.greyrock.io/todd/home-ops/pulls/718
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Old versions of VTE have a bug that breaks bash-preexec on Bash 5.3 and later. See #3456 for more information.
Even though this is an issue in VTE rather than Atuin, bundling a workaround will improve the experience for users stuck on older versions of VTE.
This PR patches bash-preexec to revert to using the
DEBUG-based method of hooking into Bash instead of the newerPS0method, which is what the VTE issue adversely affects. This is only on terminals that use the VTE integration.