Skip to content

Finish implementation of ancient PR message - #95

Merged
kellertk merged 4 commits into
aws-actions:mainfrom
Plabick:main
Sep 21, 2021
Merged

kellertk merged 4 commits into
aws-actions:mainfrom
Plabick:main

Conversation

@Plabick

@Plabick Plabick commented Jun 14, 2021 •

Copy link
Copy Markdown
Contributor

Issue #, if available:
#19
Description of changes:

  • Added an ancient PR message input. Someone seems to have started implementing it, I picked up where they left off.
  • Made minor changes to example workflow in the readme, for clarity

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Plabick Plabick changed the title Finish Implementation of Ancient PR label Finish implementation of ancient PR message Jun 14, 2021
@kellertk

kellertk commented Aug 19, 2021 •

Copy link
Copy Markdown
Member

@Plabick thank you very much for your contribution! This repository requires that all commits be signed before merging. Can you please resubmit with a signed commit?

@Plabick

Plabick commented Aug 19, 2021

Copy link
Copy Markdown
Contributor Author

@kellertk I just signed all the commits using git rebase - did that satisfy the requirement?

@Plabick
Plabick requested a review from kellertk August 19, 2021 19:52
Plabick and others added 3 commits August 19, 2021 20:39
Signed-off-by: Peter Labick <peterlabick@Peters-MacBook-Air.local>
Signed-off-by: Peter Labick <peterlabick@Peters-MacBook-Air.local>
Bumps [eslint](https://github.com/eslint/eslint) from 7.16.0 to 7.32.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](eslint/eslint@v7.16.0...v7.32.0)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@Plabick

Plabick commented Aug 20, 2021

Copy link
Copy Markdown
Contributor Author

@kellertk Sorry for the mixup - my last commits were signed but not verified. That is fixed now, everything should be good to go. By the way, thanks for making this action - my organization has been using it on internal repos and its been very helpful.

@kellertk kellertk closed this Sep 21, 2021
@kellertk kellertk reopened this Sep 21, 2021
@kellertk
kellertk merged commit 57e400a into aws-actions:main Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants