Repository navigation
Allow GetAtt outputs on SAM applications - #4665
Merged
kddejong merged 1 commit intoAug 31, 2026
Merged
Conversation
kddejong
approved these changes
Aug 31, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4665 +/- ##
==========================================
+ Coverage 94.57% 94.62% +0.05%
==========================================
Files 432 432
Lines 15393 15448 +55
Branches 2983 2995 +12
==========================================
+ Hits 14558 14618 +60
+ Misses 456 453 -3
+ Partials 379 377 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4659.
What changed
AWS::Serverless::Applicationlike nested stacks forFn::GetAttoutput attributes, allowingOutputs.*.E1010andE1040paths.Why
SAM applications are transformed into nested CloudFormation stacks, and their outputs are documented as accessible through
!GetAtt Application.Outputs.Name. After the SAM translator removal, the resource schema only exposedStackId, soOutputs.*was rejected as an unknown attribute.Validation
.venv/bin/python -m pytest test/unit/rules/functions/test_getatt.py test/unit/rules/functions/test_getatt_format.py -q.venv/bin/python -m pytest test/unit/rules/functions -q.venv/bin/python -m pytest test/unit/module/schema -q.venv/bin/ruff check src/cfnlint/schema/_getatts.py src/cfnlint/rules/functions/GetAttFormat.py test/unit/rules/functions/test_getatt.py test/unit/rules/functions/test_getatt_format.py.venv/bin/ruff format --check src/cfnlint/schema/_getatts.py src/cfnlint/rules/functions/GetAttFormat.py test/unit/rules/functions/test_getatt.py test/unit/rules/functions/test_getatt_format.pygit diff --checkus-east-1