Repository navigation
fix(lambda): Raise E2529 CloudWatch Logs subscription filter limit to 5 - #4688
Merged
kddejong merged 1 commit intoSep 9, 2026
Conversation
CloudWatch Logs now allows up to 5 subscription filters per log group (previously 2). Update E2529 so templates that attach 3-5 subscription filters to a single log group are no longer incorrectly flagged. - Bump the limit from 2 to 5 and update the rule shortdesc/description - Point source_url at the current CloudWatch Logs quotas page - Update the bad fixture and unit tests to exercise the new boundary
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4688 +/- ##
=======================================
Coverage 94.65% 94.65%
=======================================
Files 434 434
Lines 15528 15528
Branches 3011 3011
=======================================
Hits 14698 14698
Misses 453 453
Partials 377 377
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CloudWatch Logs now allows up to 5 subscription filters per log group (previously 2). Rule E2529 (
EventsLogGroupName) still enforces the old limit of 2, so it incorrectly flags valid templates that attach 3–5 subscription filters to a single log group.This raises the limit to 5 to match the current quota.
Reference: CloudWatch Logs quotas
Changes
limitfrom2to5inEventsLogGroupNameand update the ruleshortdesc/description.source_urlat the current CloudWatch Logs quotas page.test/fixtures/templates/bad/some_logs_stream_lambda.yaml) so a single log group has 6 subscription filters, exceeding the new limit.AWS::Logs::SubscriptionFilterresources and SAMCloudWatchLogsevents.docs/rules.md.Testing
pytest test/unit/rules/resources/lmbd/test_events_log_group_name.py— all passruff check,ruff format --check,isort,mypy— clean