Repository navigation
fix: Escape hyphen in SSM dynamic reference pattern - #4700
Merged
Merged
Conversation
The character class [a-zA-Z0-9_.-/] treated .-/ as an ASCII range (46-47) instead of matching a literal hyphen, so an SSM parameter segment made up solely of hyphens failed E1050 validation. Escape the hyphen to align with REGEX_DYN_REF_SSM in helpers.py. aws-cloudformation#4692
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4700 +/- ##
=======================================
Coverage 94.66% 94.66%
=======================================
Files 434 434
Lines 15561 15561
Branches 3019 3019
=======================================
Hits 14731 14731
Misses 453 453
Partials 377 377
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4692
The
_ssmpattern[a-zA-Z0-9_.-/]+treated.-/as an ASCII range (46-47) rather than a literal hyphen, so an SSM parameter segment composed solely of hyphens would fail E1050 validation. Escaping the hyphen matches the intent and aligns with the already-correctREGEX_DYN_REF_SSMinhelpers.py.Note: because cfn-lint's
patternkeyword usesre.search, the exact template in the issue lints clean today (any alphanumeric char in the path satisfies the search). This fixes the latent correctness bug and adds a regression test for the minimal failing case ({{resolve:ssm:-:1}}).Added test:
test/unit/rules/functions/test_dynamic_reference.py.