Repository navigation
fix(formats): register log group name validation correctly - #4745
Merged
kddejong merged 2 commits intoOct 20, 2026
Merged
Conversation
kddejong
approved these changes
Oct 20, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4745 +/- ##
=======================================
Coverage 94.71% 94.71%
=======================================
Files 439 439
Lines 15886 15886
Branches 3076 3076
=======================================
Hits 15046 15046
Misses 458 458
Partials 382 382
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Closes #4744.
Description of changes:
Register E1155 against
AWS::Logs::LogGroup.Nameinstead ofAWS::EC2::Subnet.Id. Invalid log group names now receive E1155, and subnet IDs are no longer checked against the log group name pattern.Add public lint API regressions for invalid and valid log group names and an invalid subnet ID. Adjust the NAT template finding count after removing the spurious format warning.
Validation: 2,975 tests and 24 subtests passed in the default suite (four data tests deselected). All 89 format-rule tests passed. Formatting, import ordering, static checks on the changed files, and diff whitespace checks passed.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.