Skip to content

fix(formats): register log group name validation correctly - #4745

Merged
kddejong merged 2 commits into
aws-cloudformation:mainfrom
0xTaoZ:fix/log-group-name-format
Oct 20, 2026
Merged

kddejong merged 2 commits into
aws-cloudformation:mainfrom
0xTaoZ:fix/log-group-name-format

Conversation

@0xTaoZ

@0xTaoZ 0xTaoZ commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Issue #, if available:

Closes #4744.

Description of changes:

Register E1155 against AWS::Logs::LogGroup.Name instead of AWS::EC2::Subnet.Id. Invalid log group names now receive E1155, and subnet IDs are no longer checked against the log group name pattern.

Add public lint API regressions for invalid and valid log group names and an invalid subnet ID. Adjust the NAT template finding count after removing the spurious format warning.

Validation: 2,975 tests and 24 subtests passed in the default suite (four data tests deselected). All 89 format-rule tests passed. Formatting, import ordering, static checks on the changed files, and diff whitespace checks passed.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov

codecov Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.71%. Comparing base (fd17da4) to head (40fd019).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4745   +/-   ##
=======================================
  Coverage   94.71%   94.71%           
=======================================
  Files         439      439           
  Lines       15886    15886           
  Branches     3076     3076           
=======================================
  Hits        15046    15046           
  Misses        458      458           
  Partials      382      382           
Flag Coverage Δ
unittests 94.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kddejong
kddejong merged commit 8f61eb5 into aws-cloudformation:main Oct 20, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

E1155 (LogGroupName) is registered under format AWS::EC2::Subnet.Id

2 participants