Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4753 +/- ##
=======================================
Coverage 94.71% 94.71%
=======================================
Files 439 439
Lines 15886 15886
Branches 3076 3076
=======================================
Hits 15046 15046
Misses 458 458
Partials 382 382
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4752.
Deployment validation overwrote the required-parameter list for each parameter, allowing missing parameters to pass whenever the last required parameter was supplied. Append each required parameter so all missing values are reported.
Add eight regression cases covering both declaration orders, either missing parameter, both missing, both supplied, and an interleaved parameter with a default.
Validation: 2,953 unit tests passed; deployment-file and template-parameter checks passed. Three audit passes covered reproduction against unchanged upstream, regression testing, and final review with all four independent fixes applied together (3,027 unit/integration tests passed plus the separate schema-updater test; four data tests retain the default exclusion).