Skip to content

fix: validate every required deployment parameter - #4753

Merged
kddejong merged 2 commits into
aws-cloudformation:mainfrom
proton0210:fix/required-deployment-parameters
Oct 20, 2026
Merged

kddejong merged 2 commits into
aws-cloudformation:mainfrom
proton0210:fix/required-deployment-parameters

Conversation

@proton0210

Copy link
Copy Markdown
Contributor

Closes #4752.

Deployment validation overwrote the required-parameter list for each parameter, allowing missing parameters to pass whenever the last required parameter was supplied. Append each required parameter so all missing values are reported.

Add eight regression cases covering both declaration orders, either missing parameter, both missing, both supplied, and an interleaved parameter with a default.

Validation: 2,953 unit tests passed; deployment-file and template-parameter checks passed. Three audit passes covered reproduction against unchanged upstream, regression testing, and final review with all four independent fixes applied together (3,027 unit/integration tests passed plus the separate schema-updater test; four data tests retain the default exclusion).

@codecov

codecov Bot commented Oct 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.71%. Comparing base (fd17da4) to head (0bcefee).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4753   +/-   ##
=======================================
  Coverage   94.71%   94.71%           
=======================================
  Files         439      439           
  Lines       15886    15886           
  Branches     3076     3076           
=======================================
  Hits        15046    15046           
  Misses        458      458           
  Partials      382      382           
Flag Coverage Δ
unittests 94.71% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kddejong
kddejong merged commit 41c1409 into aws-cloudformation:main Oct 20, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

E2900: Only the last required parameter is checked

2 participants