Repository navigation
Conversation
kddejong
approved these changes
Oct 20, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4754 +/- ##
==========================================
- Coverage 94.71% 94.70% -0.01%
==========================================
Files 439 439
Lines 15886 15895 +9
Branches 3076 3078 +2
==========================================
+ Hits 15046 15053 +7
- Misses 458 459 +1
- Partials 382 383 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4747.
Literal external resource identifiers leave remote gathered properties unavailable. The schema resolver previously compared known local values against the unresolved
$dataobject, producing false SQS and RDS findings. Treat missing remote values and deployment-time intrinsic values as unknown comparisons. Preserve that uncertainty through conditional, negated and oneOf schemas, while retaining literal reference comparisons explicitly requested by cfnContext.Add the reported SQS/RDS reproduction, known cluster mismatch controls, tests for missing and false-like values, and composite-schema regressions. Existing API Gateway and VPC reference-comparison tests remain passing.
Validation: 547 focused tests passed. Three audit passes covered upstream reproduction, full unit/non-regression checks, and final source review with all four independent fixes applied together (3,027 unit/integration tests passed plus the separate schema-updater test; four data tests retain the default exclusion).