Repository navigation
Conversation
kddejong
approved these changes
Oct 21, 2026
The pricing usage type shortens sizes from 2xlarge up (mq.m7g.2xl), and get_mq_pricing() only mapped mq.m5.2xl and mq.m5.4xl back to the names the Amazon MQ API uses. So the m7g sizes from 2xlarge to 16xlarge (36 regions) and the m7i 2xlarge and 4xlarge (ap-east-2, ap-southeast-6) were listed under the short names, and E3670 rejected the real ones. Expand any "<N>xl" size to "<N>xlarge" in the script, and apply the same mapping to the committed instancetype_enum.json. Only those names change; the file was not regenerated from the Pricing API.
kddejong
force-pushed
the
fix/e3670-mq-xlarge-instance-types
branch
from
October 21, 2026 19:12
b5bacba to
7ec6727
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4760 +/- ##
=======================================
Coverage 94.67% 94.67%
=======================================
Files 439 439
Lines 15969 15969
Branches 3095 3095
=======================================
Hits 15118 15118
Misses 468 468
Partials 383 383
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes #4751
Description of changes:
The Price List usage type shortens Amazon MQ sizes from 2xlarge up (
mq.m7g.2xl), andget_mq_pricing()only mappedmq.m5.2xlandmq.m5.4xlback to the full names. So the enum listedmq.m7g.2xlthroughmq.m7g.16xl(36 regions) andmq.m7i.2xl/4xl(ap-east-2, ap-southeast-6), and E3670 rejectedmq.m7g.2xlargeand the other names the Amazon MQ API and the docs use.scripts/update_specs_from_pricing.py: replace the two-entry remap withget_mq_instance_type(), which expands any<N>xlsize to<N>xlarge. The m5 names come out the same as before.aws_amazonmq_broker/instancetype_enum.json: the same mapping applied to the committed file. I don't have Pricing API access, so this is not a regeneration: I ran the script's ownget_mq_instance_type()over every region list and wrote the file back in the formatwrite_output()uses. Only thexlnames change (184 lines renamed, nothing added or removed), and every size keeps its place in the sorted lists.mq.m4.largeandmq.t2.micro, which the issue also mentions, are left alone here: the Price List still lists them, so removing them by hand would be undone by the next pricing run.Tests: a new parametrized test for
BrokerInstanceTypeEnum(all five m7g sizes in us-east-1, the two m7i sizes in ap-east-2 and ap-southeast-6, andmq.m7g.2xl, an unknown size and an m7i size outside those regions as failures), and a test intest_update_specs_from_pricing.pythat runsget_mq_pricing()on mocked Price List products. Onmain9 of the new cases fail; with this change they pass, the full test suite passes (Python 3.13), andpre-commit runon the changed files passes. No snapshot undertest/fixtures/resultsis affected.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.