Repository navigation
fix(E3620): Add db.serverless to the DocumentDB instance classes - #4761
Merged
kddejong merged 1 commit intoOct 21, 2026
Merged
Conversation
kddejong
approved these changes
Oct 21, 2026
DocumentDB Serverless instances use the db.serverless class, but the Price List prices them by capacity unit, outside the "Database Instance" products that get_results() reads. The class never reached the enum, so E3620 rejected it in every region. Seed db.serverless as a default for DocumentDB, as the script already does for Neptune (aws-cloudformation#3009), and add it to every region list in the committed dbinstanceclass_enum.json. Only that value is added; the file was not regenerated from the Pricing API.
kddejong
force-pushed
the
fix/e3620-docdb-serverless
branch
from
October 21, 2026 18:08
7c4ece6 to
deaac79
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4761 +/- ##
=======================================
Coverage 94.66% 94.66%
=======================================
Files 439 439
Lines 15963 15963
Branches 3091 3091
=======================================
Hits 15112 15112
Misses 468 468
Partials 383 383
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes #4750
Description of changes:
DocumentDB Serverless instances use the
db.serverlessinstance class (docs), but the Price List prices them by capacity unit, outside theDatabase Instanceproducts the pricing script reads. So the class never reached the enum and E3620 rejected it in every region.scripts/update_specs_from_pricing.py: passdefault=set(["db.serverless"])for DocumentDB, the same way Add db.serverless to neptune instance classes #3009 did for Neptune.aws_docdb_dbinstance/dbinstanceclass_enum.json: adddb.serverlessto every region list, which is what the script now produces. I don't have Pricing API access, so the file was edited, not regenerated: one sorted line per region (34), nothing else changes.AWS's Supported instance classes by Region table marks Serverless as supported in every DocumentDB Region, the same 34 Regions the enum lists, so the default applies to all of them, as it does for Neptune.
Tests: a new parametrized test for
DBInstanceClassEnum(db.serverlessin us-east-1 and il-central-1 as in the issue, plus a class DocumentDB doesn't offer and one missing from a region, which are still reported), and a test intest_update_specs_from_pricing.pythat runsmain()with mocked Price List pages and checks the DocumentDB output includesdb.serverless. Thedb.serverlesscase and themain()test fail onmainand pass with this change; the other three cases pass on both. The full test suite passes (Python 3.13), andpre-commit runon the changed files passes. No snapshot undertest/fixtures/resultsis affected.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.