Repository navigation
Fix crash when a resource's Metadata is not an object - #4784
Merged
kddejong merged 1 commit intoOct 21, 2026
Merged
Conversation
kddejong
force-pushed
the
fix-null-resource-metadata
branch
from
October 21, 2026 00:00
e30622d to
c61d33a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4784 +/- ##
=======================================
Coverage 94.70% 94.70%
=======================================
Files 439 439
Lines 15895 15898 +3
Branches 3078 3079 +1
=======================================
+ Hits 15053 15056 +3
Misses 459 459
Partials 383 383
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Oct 21, 2026
kddejong
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #4769
Description of changes:
Template.get_directivesnow skips a resource whoseMetadatais not an object (null, list, string) instead of raisingAttributeError.None is not of type 'object', 'array'.Metadata. It fails without the fix and passes with it.The top-level
Metadatacrash (#4768) is in a different code path (ConfigMixIn.set_template_args), so I'll send it as a separate PR.