Repository navigation
Conversation
kddejong
approved these changes
Oct 23, 2026
kddejong
force-pushed
the
fix/rds-mysql-major-engine-version
branch
from
October 23, 2026 21:31
52e25e5 to
c99c74d
Compare
E3691 (AWS::RDS::DBInstance) and E3690 (AWS::RDS::DBCluster) flagged major-only EngineVersion values such as "8.0" for mysql and "10.11" for mariadb. RDS accepts these and resolves them to a recent minor release. update_schemas_from_aws_api.py only derived shortened versions for postgres (major) and aurora-mysql (major.minor). Derive major.minor values for mysql and mariadb in write_db_instance, and for mysql in write_db_cluster, the same way aws-cloudformation#3850 did for postgres. The engine_version.json data files are regenerated by running the script's writer functions on the versions already present in them, so no AWS API call was needed. The *_deprecated writers are unchanged. Fixes aws-cloudformation#4774
kddejong
force-pushed
the
fix/rds-mysql-major-engine-version
branch
from
October 23, 2026 23:30
c99c74d to
bf38945
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4796 +/- ##
=======================================
Coverage 94.68% 94.68%
=======================================
Files 439 439
Lines 16004 16004
Branches 3108 3108
=======================================
Hits 15153 15153
Misses 468 468
Partials 383 383
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: Fixes #4774
Description of changes:
scripts/update_schemas_from_aws_api.pyadds shortened engine versions only forpostgres(major) andaurora-mysql(major.minor). As a result themysqlandmariadbenums contain only fullX.Y.Zversions, and a major-onlyEngineVersionsuch as"8.0"(mysql) or"10.11"(mariadb) fails E3691, even though RDS accepts it.AWS::RDS::DBClusterwithEngine: mysqlhas the same problem under E3690.write_db_instancenow derivesmajor.minorvalues formysqlandmariadb, andwrite_db_clusterdoes the same formysql.*_deprecatedwriters are left unchanged on purpose. Deriving majors there the wayaurora-mysqldoes would mark a major as deprecated as soon as any one of its minors is, somysql8.0would pass E3691 but trip W3691. The trade-off is that a major whose minors are all deprecated (mysql5.7,mariadb10.5) now passes E3691 without a W3691 warning. Flagging only those majors would need the deprecated writers to see the available versions too; happy to do that here or in a follow-up if you prefer.aws_rds_dbinstance/engine_version.json(+16: 5 mysql, 11 mariadb) andaws_rds_dbcluster/engine_version.json(+5 mysql) by running the script's own writer functions on the versions already in those files, so no AWS API call was made. Before the script change, the same run reproduced both files byte-for-byte.8.0/8.4and mariadb10.11/11.4pass, that postgres16and aurora-mysql8.0still pass, and that an invalid9.99still fails. The new major-only cases fail without the data change. No snapshot changes.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.