Repository navigation
Don't report E3049 when HealthCheckPort is omitted - #4829
Merged
kddejong merged 1 commit intoOct 22, 2026
Merged
Conversation
kddejong
approved these changes
Oct 22, 2026
For HTTP, HTTPS, TCP, TLS, UDP, TCP_UDP, QUIC and TCP_QUIC target groups an omitted HealthCheckPort defaults to traffic-port, so the template is valid. Only report a missing HealthCheckPort when the protocol is known to have a different default. Fixes aws-cloudformation#4825
kddejong
force-pushed
the
fix-e3049-omitted-healthcheckport
branch
from
October 22, 2026 15:08
006e539 to
a3f49e4
Compare
kddejong
approved these changes
Oct 22, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4829 +/- ##
==========================================
- Coverage 94.68% 94.67% -0.01%
==========================================
Files 439 439
Lines 15973 15984 +11
Branches 3097 3100 +3
==========================================
+ Hits 15124 15133 +9
- Misses 467 468 +1
- Partials 382 383 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: Fixes #4825
Description of changes:
E3049 reported a target group that doesn't set
HealthCheckPort. For HTTP, HTTPS, TCP, TLS, UDP, TCP_UDP, QUIC and TCP_QUIC target groups the omitted property defaults totraffic-port(docs), so the template is valid.HealthCheckPortis omitted, the rule now looks at the target groupProtocoland only reports when the protocol is known to have a different default (for exampleGENEVE).Protocolis missing or set with a function, the rule doesn't report, since the default can't be determined.HealthCheckPort: "8088") is still reported.Tests: updated the existing omitted-
HealthCheckPortcase (HTTP, now no error) and added cases forGENEVE(still reported) and aRefprotocol (not reported).By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.