Repository navigation
fix(E3695): Allow redis EngineVersion 6.x on CacheCluster - #4906
Merged
kddejong merged 1 commit intoOct 27, 2026
Merged
Conversation
E3695 rejected EngineVersion "6.x" for a redis AWS::ElastiCache::CacheCluster. ElastiCache accepts it: the "Engine versions and upgrading in ElastiCache" page of the ElastiCache User Guide (ElastiCache version 6.2 for Redis OSS section) says that specifying engine version 6.x in the API results in the latest minor version of Redis OSS 6. DescribeCacheEngineVersions only returns concrete versions, so 6.x never reached the generated enum. Add "6.x" to the redis versions in write_elasticache_engines when the API returns a 6.* version, and regenerate engine_version.json by running the writer on the versions already in it (no AWS API call). Other engines are unchanged. Fixes aws-cloudformation#4823
kddejong
force-pushed
the
fix/e3695-redis-6x
branch
from
October 27, 2026 18:34
7a39d80 to
03a8629
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4906 +/- ##
=======================================
Coverage 94.68% 94.68%
=======================================
Files 441 441
Lines 16058 16058
Branches 3114 3114
=======================================
Hits 15204 15204
Misses 470 470
Partials 384 384
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes #4823
Description of changes:
E3695 rejected
EngineVersion: "6.x"for a redisAWS::ElastiCache::CacheCluster. The ElastiCache User Guide page Engine versions and upgrading in ElastiCache (ElastiCache version 6.2 for Redis OSS section) says 6.x resolves to the latest Redis OSS 6 minor version, butDescribeCacheEngineVersionsonly returns concrete versions.write_elasticache_enginesnow adds6.xfor redis when a6.*version is present, and I regeneratedengine_version.jsonfrom the versions already in it, so no API call was needed. Other engines are unchanged. The rule tests and pre-commit pass, and the full suite shows no new failures.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.