Repository navigation
fix(E3046): allow the awslogs flush-interval and buffered-events options - #4925
Merged
kddejong merged 1 commit intoNov 3, 2026
Conversation
The awslogs LogConfiguration schema listed eight option names and reported any other as not one of the list. awslogs-force-flush-interval-seconds and awslogs-max-buffered-events are options of the Docker awslogs driver that ECS accepts on EC2 task definitions, and the CloudFormation schema does not limit the Options keys. Add both to the allowed names. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
kddejong
force-pushed
the
fix/e3046-awslogs-docker-options
branch
from
November 2, 2026 23:27
af5717d to
214bcf1
Compare
kddejong
approved these changes
Nov 2, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4925 +/- ##
=======================================
Coverage 94.74% 94.74%
=======================================
Files 442 442
Lines 16145 16145
Branches 3138 3138
=======================================
Hits 15296 15296
Misses 469 469
Partials 380 380
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #4848
Description of changes:
The E3046 schema for
awslogs(aws_ecs_taskdefinition/logging_configuration.json) restricts theOptionskeys to eight names.awslogs-force-flush-interval-secondsandawslogs-max-buffered-eventsare options of the Docker awslogs driver that ECS accepts on EC2 task definitions, and the CloudFormation registry schema typesOptionsas a free map of strings, so the template from the issue was reported as "not one of [...]" although CloudFormation and ECS accept it. This adds the two names to the allowed list.Note: ECS rejects these two options on Fargate task definitions. The schema is applied whatever
RequiresCompatibilitiesis, so after this change they are no longer flagged there either (they were flagged before only because they were missing from the list). Making that check Fargate-aware (looking atRequiresCompatibilities) would be a separate change; happy to follow up on it if that is wanted.Tests: a case with both options in
test_task_definition_log_configuration.py, which fails without the change; the ECS rule tests pass (116 tests) and the template from the issue now lints clean. Not tested: deploying the stack.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
This change was prepared with Claude Code.