Skip to content

Update PyPI workflow and snapshot results script - #4990

Merged
kddejong merged 2 commits into
aws-cloudformation:mainfrom
satyakigh:fix/update-snapshot-workflow
Nov 5, 2026
Merged

kddejong merged 2 commits into
aws-cloudformation:mainfrom
satyakigh:fix/update-snapshot-workflow

Conversation

@satyakigh

@satyakigh satyakigh commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Description of changes:

  • Validate the release tag against the package version and attach source distributions to stable, non-prerelease GitHub releases before publishing to PyPI.
  • Include bad/override templates in automatic snapshot-result discovery.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@satyakigh
satyakigh requested a review from kddejong November 4, 2026 21:02
@codecov

codecov Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.80%. Comparing base (588d3c5) to head (3275610).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4990      +/-   ##
==========================================
+ Coverage   94.74%   94.80%   +0.06%     
==========================================
  Files         442      441       -1     
  Lines       16145    16165      +20     
  Branches     3138     3135       -3     
==========================================
+ Hits        15296    15326      +30     
+ Misses        469      463       -6     
+ Partials      380      376       -4     
Flag Coverage Δ
unittests 94.80% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kddejong
kddejong merged commit 0772607 into aws-cloudformation:main Nov 5, 2026
24 checks passed
kddejong added a commit that referenced this pull request Nov 5, 2026
The sdist upload ran between the build and the publish step, so a
GitHub API failure stopped the release from reaching PyPI. Publishing
is the irreversible step, so it now runs first and a problem attaching
the asset can no longer block it.

Add --clobber to gh release upload so a re-run after a partial failure
is idempotent instead of failing on the asset already present.

Pin pypa/gh-action-pypi-publish to the v1.14.3 commit. release/v1 is a
branch that moves on every PyPA release, and this job holds
id-token: write for trusted publishing.

Follow-up to #4990.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants