Feature Request: Add support for the pre-commit framework #22

Activity

1. dontirun

   changed the title [-]Add support for the pre-commit framework[/-] [+]Feature Request: Add support for the pre-commit framework[/+] on Jun 22, 2020
2. nathanataws

   added

   enhancementNew feature or requestNew feature or request

   on Jun 23, 2020
3. nathanataws commented on Jun 23, 2020

   

   nathanataws

   on Jun 23, 2020

   Contributor

   More actions

   This is very reasonable ask. We're looking at integrations right now. We'll pull this into that discussion.
4. johnttompkins commented on Feb 25, 2021

   

   johnttompkins

   on Feb 25, 2021

   Contributor

   More actions

   Looks like pre-commit natively supports rust as a buildable language plugin. If this is the case, this should be straightforward to offer.

   👍React with 👍1Reacted by Pat Myron
5. benbridts commented on Feb 25, 2021

   

   benbridts

   on Feb 25, 2021

   Contributor

   More actions

   There are still some hurdles (at least the last time I tried):

   • You need to have rust installed (not much to do about that, and you can install cfn-guard yourself and use the system "language")
   • pre-commit passes all matching files on one invocation (or at least does so by default). I couldn't get it to invoke cfn-guard multiple times (that's why I created [Enhancement] Run cfn-guard check without parameters #62 )
6. priyap286

   added a commit that references this issue on May 17, 2021

   Merge pull request #22 from aws-cloudformation/fix-warning-build-errors

   ...

   68cf933
7. barnesrobert commented on Jun 1, 2021

   

   barnesrobert

   on Jun 1, 2021

   More actions

   +1 to this issue. Pre-commits are a vital way of remediating latent vulnerabilities before they're committed.
8. shreyasdamle

   added

   next-release

   on Nov 16, 2021
9. razcloud

   removed

   next-release

   on Apr 8, 2022
10. razcloud

    added

    needs-research

    on May 2, 2022
11. kgrvamsi commented on Apr 26, 2023

    

    kgrvamsi

    on Apr 26, 2023

    More actions

    Do we have any update on this Feature request to support pre-commit hooks?
12. kgrvamsi commented on Apr 27, 2023

    

    kgrvamsi

    on Apr 27, 2023

    More actions

    if the project already have a .pre-commit-confg.yaml i see the below config works

      - repo: local
        hooks:
          - id: cfn-guard
            name: Run Cfn Guard
            language: system
            entry: "cfn-guard validate -r ./cfn-rules/cloudformation/aws/ --data ./cdk.out/"
            pass_filenames: false
           
    
13. joshfried-aws commented on Jun 22, 2023

    

    joshfried-aws

    on Jun 22, 2023

    Contributor

    More actions

    Hi @kgrvamsi we do not have any updates here yet.
14. dannyvassallo

    added 2 commits that reference this issue on Jul 9, 2024

    feat(pre-commit-hook): Use filenames from hook, update api, and add m…

    ...

    5d23c99

    feat(pre-commit-hook): Initial implementation in python #22 (#524)

    ...

    57d712c
15. dannyvassallo commented on Jul 9, 2024

    

    dannyvassallo

    on Jul 9, 2024

    Contributor

    More actions

    @kgrvamsi the initial implementation with documentation has been merged to the main branch of the repo. I'm going to close this issue and we can track anything that comes up in the future in a new one. Thanks to everyone for their patience on this and we hope you enjoy using the new hook!
16. dannyvassallo

    closed this as completedon Jul 9, 2024
17. dannyvassallo

    added 2 commits that reference this issue on Jul 10, 2024

    feat(pre-commit-hook): Initial implementation in python aws-cloudform…

    ...

    8b1606c

    Squashed commit of the following:

    ...

    0e16fe3
18. joshfried-aws

    added a commit that references this issue on Nov 22, 2024

    feat(pre-commit-hook): Initial implementation in python aws-cloudform…

    ...

    f0f7a90