Repository navigation
+[fancy-regex] Added support for advanced regular expressions - #326
Merged
Merged
Conversation
This reverts commit db23c3e.
This reverts commit bb52c24.
This reverts commit d7cd5af.
This reverts commit a24c6d8.
This reverts commit 12f4711.
This reverts commit 0e5be29.
This reverts commit c5ba63d.
This reverts commit cdd0516.
This reverts commit c9df155.
# Conflicts: # guard/Cargo.toml # guard/src/commands/validate/cfn.rs
akshayrane
requested review from
Brianwithay21,
dchakrav-github,
joshfried-aws,
razcloud,
reza-aws and
wkexiang
February 3, 2023 21:19
joshfried-aws
left a comment
joshfried-aws
left a comment
Contributor
There was a problem hiding this comment.
Most of it looks great to me. Left 2 comments on some stuff I'd like to further clarify before merging.
joshfried-aws
approved these changes
Feb 6, 2023
Brianwithay21
approved these changes
Feb 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Internal, TIX-212
Related work:
Description of changes:
Added support for advanced regular expressions that support features such as look-ahead and look-behinds.
Replaced the standard
regexcrate withfancy-regexsince the latter uses a hybrid approach and automatically delegates the basic regular expressions to the native engine.Source
fancy-regex:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license