Repository navigation
[Enhancement]: Adding support for calling functions inline - #400
Merged
Merged
Conversation
joshfried-aws
requested review from
Brianwithay21,
Neel-Renavikar,
akshayrane,
brianlaoaws,
frankret,
pamkuang,
razcloud,
reza-aws,
rpdutt,
setttings and
wkexiang
August 23, 2023 20:11
Brianwithay21
approved these changes
Aug 23, 2023
akshayrane
reviewed
Aug 23, 2023
akshayrane
approved these changes
Aug 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#374
Description of changes:
This pr adds functionality to both the parser and the guard evaluation engine to allow users to write functions inline. Previously users would have to assign the result from a function to a variable, and then use an access query to evaluate the result. Now users are able to call functions directly, and compare them.
Please note: although this PR addresses most cases where functions can be called inline, there's still a limitation on calling them on the LHS of an operator. We are still researching if this is possible achieve in 3.x
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license