Repository navigation
fix workflow for publishing to ecr - #408
Merged
Merged
Conversation
Contributor
Author
|
Seems to have fixed it we can see the job was skipped here: https://github.com/joshfried-aws/cloudformation-guard/actions/runs/6124753342 |
joshfried-aws
requested review from
Brianwithay21,
akshayrane,
razcloud and
reza-aws
September 8, 2023 17:39
razcloud
approved these changes
Sep 8, 2023
joshfried-aws
changed the title
akshayrane
approved these changes
Sep 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Previous PR had broken the step to deploy to ECR. Attempting to fix this by replacing double quotes with single quotes as per github docs
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license