Repository navigation
[Bugfix]: Loader can panic when handling nested maps - #415
Merged
Merged
Conversation
joshfried-aws
changed the title
joshfried-aws
changed the title
razcloud
self-requested a review
November 17, 2023 04:33
razcloud
approved these changes
Nov 17, 2023
akshayrane
approved these changes
Nov 17, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
There's an issue in cfn-guard where some nested maps can cause the loader to crash. This bug has been addressed in this PR and added a test case to verify this issue will not persist.
Currently when we
drainour stack for all the items, we assumed they'd all be string types (keys). This means we would only handle the case where the type was of string, and then we created an unreachable block. This is not true in the case of yaml that contains nested JSON/curly brace maps. To fix this we add a check to see if we have a map type, and if that is the case we just skip this iteration.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license