Repository navigation
[BugFix]: fix for converting serde_yaml::Value into internal Value type - #422
Merged
Merged
Conversation
joshfried-aws
requested review from
brianlaoaws,
pamkuang,
razcloud and
reza-aws
November 30, 2023 14:28
rpdutt
approved these changes
Nov 30, 2023
brianlaoaws
approved these changes
Nov 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Using our fuzzer I discovered another bug involved with keys for maps. This time it was when trying to convert from serde_yaml -> our internal value type. We now error our if the value for the key in the
serde_yaml::Value::Mapis not a String. This is consistent with the logic throughout our project. Unfortunately since serde_yaml does not provide the location, our error message doesn't include the location where this error occurs.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license