Repository navigation
[BugFix]: fix to catch panic when parsing inner portion of a string - #426
Merged
Merged
Conversation
joshfried-aws
requested review from
Brianwithay21,
Neel-Renavikar,
brianlaoaws,
frankret,
minhphuong98,
pamkuang,
razcloud,
reza-aws,
rpdutt,
setttings and
wkexiang
November 30, 2023 18:55
joshfried-aws
changed the title
minhphuong98
approved these changes
Nov 30, 2023
setttings
approved these changes
Nov 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Running the guard fuzzer i discovered a bug similar to one we had in the
parse_inner_regexfunction inparser.rslast year. The solution here is the same, we check if our remainder is empty while we are still looping if it is we return an error.Test case has been added to verify the fix
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license