Repository navigation
[Misc]: adding multiple targets for install script job - #435
Merged
Merged
Conversation
joshfried-aws
requested review from
Brianwithay21,
Neel-Renavikar,
brianlaoaws,
frankret,
minhphuong98,
razcloud,
rpdutt,
setttings and
wkexiang
December 12, 2023 18:19
rpdutt
approved these changes
Dec 12, 2023
brianlaoaws
approved these changes
Dec 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#385
Description of changes:
Previously we were just testing the already merged version of the script, this PR makes it so we test the local version of it. We also added both 2 new macos targets to test our install script works on supported platforms except for arm64 linux since Github does not yet have a runner for this.
Previous commits were done to test, and ensure jobs fail when the script fails.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license