Repository navigation
[Code Quality]: removing unecessary result return types - #445
Merged
Merged
Conversation
… up handling of them
joshfried-aws
requested review from
Brianwithay21,
Neel-Renavikar,
akshayrane,
brianlaoaws,
minhphuong98,
razcloud,
reza-aws,
rpdutt,
setttings and
wkexiang
January 17, 2024 15:47
rpdutt
approved these changes
Jan 17, 2024
reza-aws
approved these changes
Jan 17, 2024
brianlaoaws
approved these changes
Jan 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
I recently noticed the extract variables, and root_scope functions didn't need to have a Result as their return type since there's no path where they error out. This PR removes those return types from the signature, and addresses all the handling of these functions throughout the codebase as necessary.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license