Repository navigation
[Misc]: updating build and unit tests to include a windows job - #449
Merged
joshfried-aws merged 6 commits intoFeb 7, 2024
Merged
Conversation
joshfried-aws
requested review from
Brianwithay21,
akshayrane,
brianlaoaws,
dannyvassallo,
minhphuong98,
razcloud,
rpdutt and
wkexiang
February 1, 2024 20:31
dannyvassallo
approved these changes
Feb 1, 2024
rpdutt
approved these changes
Feb 1, 2024
akshayrane
reviewed
Feb 1, 2024
| strategy: | ||
| matrix: | ||
| os: [ubuntu-latest, macos-latest, macos-13-xlarge] | ||
| os: [ubuntu-latest, macos-latest, macos-13-xlarge, windows-latest] |
Contributor
There was a problem hiding this comment.
May be we'd need to use platform agnostic line endings in our tests?
#[cfg(windows)]
const LINE_ENDING: &'static str = "\r\n";
#[cfg(not(windows))]
const LINE_ENDING: &'static str = "\n";
Contributor
Author
There was a problem hiding this comment.
This is not what we need here, since its the fixtures throwing us off.
joshfried-aws
force-pushed
the
update_runners
branch
from
February 5, 2024 16:58
698e371 to
3f93aea
Compare
dannyvassallo
pushed a commit
to dannyvassallo/cloudformation-guard
that referenced
this pull request
Feb 9, 2024
…loudformation#449) * [Misc]: updating build and unit tests to include a windows job * attempting to fix CRLF issue when comparing buffer to saved files * attempting to fix windows pathing issues * adding an early return for buffer comparisons on windows systems * fix for failing parse_tree expected_failures integ test * typo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
n/a
Description of changes:
Updated our CI to add windows to the matrix for build and run tests to make this pass, we our using an early return whenever we compare buffer outputs due to inconsistencies between windows and unix systems
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license