Repository navigation
fix rulegen invalid parameter - #453
Merged
joshfried-aws merged 2 commits intoFeb 9, 2024
Merged
joshfried-aws merged 2 commits into
joshfried-aws merged 2 commits into
Conversation
joshfried-aws
approved these changes
Feb 8, 2024
joshfried-aws
requested changes
Feb 8, 2024
joshfried-aws
left a comment
joshfried-aws
left a comment
Contributor
There was a problem hiding this comment.
hi @sejimhp thank you for submitting this pr, please rebase for latest changes so the CI passes.
sejimhp
force-pushed
the
feature/fix-README-invalid-parameter
branch
from
February 9, 2024 07:02
7d853e0 to
9110dc6
Compare
Contributor
Author
|
@joshfried-aws Thanks for the review. I rebased this branch with the latest main. |
joshfried-aws
self-requested a review
February 9, 2024 15:12
joshfried-aws
approved these changes
Feb 9, 2024
dannyvassallo
approved these changes
Feb 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Fixed a wrong parameter in the README of rulegen.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license