Skip to content

[Enhancement] Show full path to file #410 - #457

Merged
dannyvassallo merged 3 commits into
aws-cloudformation:mainfrom
dannyvassallo:full_paths
Feb 13, 2024
Merged

dannyvassallo merged 3 commits into
aws-cloudformation:mainfrom
dannyvassallo:full_paths

Conversation

@dannyvassallo

Copy link
Copy Markdown
Contributor

Issue #, if available: 410

Description of changes:

  • Exposes the full path of the data file name during validation
  • Sanitizes the path from the CLI output during tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Comment thread guard/src/commands/validate.rs Resolved
Comment thread guard/tests/utils.rs Resolved
Comment thread guard/tests/utils.rs Resolved
Comment thread guard/tests/utils.rs Resolved

@joshfried-aws joshfried-aws left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Comment thread guard/tests/utils.rs Resolved
@dannyvassallo
dannyvassallo merged commit 786c7b3 into aws-cloudformation:main Feb 13, 2024
@dannyvassallo
dannyvassallo deleted the full_paths branch February 13, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants