Repository navigation
[BugFix]: fix for regression regarding delimiters for show summary - #494
Merged
Merged
Conversation
… validate command
dannyvassallo
approved these changes
Apr 12, 2024
razcloud
self-requested a review
April 12, 2024 14:49
razcloud
approved these changes
Apr 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#493
Description of changes:
After migrating to clap derive, there was a regression regarding the delimiter specified for show-summary argument on the validate command. This PR addresses that issue, and provides integration tests to prevent something like this happening again
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license