Repository navigation
fix(opeartor): != not working as expected - #506
Merged
Merged
Conversation
dannyvassallo
approved these changes
May 7, 2024
brianlaoaws
approved these changes
May 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#478
Description of changes:
This PR addresses an issue where the guard evaluation engine was not properly handling successful
!=checks.This was due to an inconsistency here where we compare sizes of lhs and rhs, and depending on which one is bigger, we use that to construct the diff (filtering for elements that are not in the other). The problem with this is when we checked to negate the clause here it was always constructed using the LHS. To fix this, we need to follow the same logic as in the previous link, except we need to invert the size check for lhs and rhs, and also ensure the operator is an Eq, and then we can construct the diff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license