Repository navigation
fix(github-action): Analyze checkout & upload bug - #519
Merged
dannyvassallo merged 9 commits intoJun 7, 2024
Merged
Conversation
joshfried-aws
approved these changes
Jun 7, 2024
joshfried-aws
left a comment
joshfried-aws
left a comment
Contributor
There was a problem hiding this comment.
nit: title should replace the word bug with fix according to the conventional commits spec
| steps: | ||
| - name: CloudFormation Guard validate | ||
| uses: aws-cloudformation/cloudformation-guard@action-v0.0.2 | ||
| uses: aws-cloudformation/cloudformation-guard@action-v0.0.3 |
Contributor
There was a problem hiding this comment.
nit: i assume theres a way we can make this less tedious when bumping the version?
Contributor
Author
There was a problem hiding this comment.
we could just x.x.x it and leave it at that or template it.
dannyvassallo
changed the title
SG622
approved these changes
Jun 7, 2024
joshfried-aws
pushed a commit
to joshfried-aws/cloudformation-guard
that referenced
this pull request
Nov 22, 2024
…#519) Fix publicCheckout & uploadCodeScan on schedule events
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Fixes missing SHA and ref for checkoutPublicRepository & uploadCodeScan
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license