Repository navigation
feat(ts-lib): Handle single files / recursively handle directories - #554
Merged
dannyvassallo merged 2 commits intoAug 30, 2024
Merged
Conversation
… rules and data
joshfried-aws
approved these changes
Aug 29, 2024
| }; | ||
|
|
||
| async function readFiles(dirPath: string, supportedExtensions: string[]): Promise<TraversalResult> { | ||
| async function readFiles(pathOrFile: string, supportedExtensions: string[]): Promise<TraversalResult> { |
Contributor
There was a problem hiding this comment.
nit: this should just either be path or dirOrFile (i think path is best)
racicot-amzn
approved these changes
Aug 30, 2024
joshfried-aws
pushed a commit
to joshfried-aws/cloudformation-guard
that referenced
this pull request
Nov 22, 2024
…ws-cloudformation#554) * feat(ts-lib): Handle single files / recursively handle directories on rules and data * feat(ts-lib): Addressing feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
547 & 545
Description of changes:
Updated the typescript library to handle single files and files in nested directories.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license