Skip to content

fix(ts-lib): Bump dependencies for security alert & update imports for wasm-pack - #560

Merged
dannyvassallo merged 3 commits into
aws-cloudformation:mainfrom
dannyvassallo:security_alert_axios
Sep 3, 2024
Merged

dannyvassallo merged 3 commits into
aws-cloudformation:mainfrom
dannyvassallo:security_alert_axios

Conversation

@dannyvassallo

@dannyvassallo dannyvassallo commented Sep 3, 2024 •

Copy link
Copy Markdown
Contributor

Issue #, if available:

https://github.com/aws-cloudformation/cloudformation-guard/security/dependabot/19

You can verify the override works by checking the package.lock to see the bump from 26 -> 28

Description of changes:

  • Updates the impacted version of axios and its consumer wasm-pack.
  • Updates the imports on the lib.rs file so that wasm-pack doesn't fail to run.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Comment thread guard/src/lib.rs Resolved

@mrinaudo-aws mrinaudo-aws left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dannyvassallo
dannyvassallo merged commit f7901d0 into aws-cloudformation:main Sep 3, 2024
@dannyvassallo
dannyvassallo deleted the security_alert_axios branch September 3, 2024 17:29
joshfried-aws pushed a commit to joshfried-aws/cloudformation-guard that referenced this pull request Nov 22, 2024
…r wasm-pack (aws-cloudformation#560)

* fix(ts-lib): Bump dependencies for security alert

* fix(ts-lib): wasm-pack fails without this

* fix(ts-lib): Addressing feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants