Skip to content

[fix] explicity set resolver=2 on root virtual workspace. - #593

Merged
joshfried-aws merged 1 commit into
aws-cloudformation:mainfrom
lizhunt-aws:main
Dec 8, 2024
Merged

joshfried-aws merged 1 commit into
aws-cloudformation:mainfrom
lizhunt-aws:main

Conversation

@lizhunt-aws

@lizhunt-aws lizhunt-aws commented Dec 5, 2024 •

Copy link
Copy Markdown
Contributor

Issue #, if available:
#590

Description of changes:

previously, a change to wasm-bindgen was causing the build to fail (see: linked issue) when taking the newest version (i.e. by building the project using unlocked dependencies). the error message has been updated in an unreleased change in the wasm-bindgen macro crate (ref).

note this warning when building the project:

> cargo build
warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"`
note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest
note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest
note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions
...

https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions

If you are using a virtual workspace, you will still need to explicitly set the resolver field in the [workspace] definition if you want to opt-in to the new resolver.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@joshfried-aws
joshfried-aws merged commit 52063c2 into aws-cloudformation:main Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants