Repository navigation
chore: bumping up nom and nom_locate - #612
Merged
Merged
Conversation
dannyvassallo
approved these changes
Feb 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#608
Description of changes:
This PR addresses an issue found by the cargo-audit scanner. It flagged the lexical-core crate for multiple soundness violations. To address this issue we needed to bump up our dependency on both nom parser, and nom locate crates to 7.x and 4.x respectively.
Bumping up nom required us to change the signature for our parser functions that accept an Fn to FnMut this also required us to mark some of these variables as mutable. In addition to this the ParserError type we implement needs to implement
ContextErrortrait as well asFromExternalErrorwhere necessary.Other changes required us to go from using a nom parser named separated_nonempty_list to separated_list1, similarly we needed to go from using a parser fn named separated_list to separated_list0.
There were also a few instances where we needed to be more verbose for the typing in closures, by including the lifetime. Without this the rust compiler can't guarantee the safeness of these lifetimes.
The full changelog mentioning breaking changes can be found here: https://github.com/rust-bakery/nom/blob/6.0.0/CHANGELOG.md
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license