Repository navigation
Bump Netty to 4.1.133.Final and update trivyignore - #1374
Merged
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1374 +/- ##
=============================================
- Coverage 85.71% 69.39% -16.33%
- Complexity 19 704 +685
=============================================
Files 3 63 +60
Lines 49 3437 +3388
Branches 5 487 +482
=============================================
+ Hits 42 2385 +2343
- Misses 3 861 +858
- Partials 4 191 +187 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ezhang6811
enabled auto-merge (squash)
May 7, 2026 01:30
wangzlei
pushed a commit
that referenced
this pull request
Aug 19, 2026
## Description of changes Bumps Netty from `4.1.136.Final` to `4.1.137.Final` to fix **CVE-2026-59903**. The Trivy image scan in `pr-build` currently fails on: | Library | Vulnerability | Severity | Installed | Fixed | |---|---|---|---|---| | `io.netty:netty-codec-http` | `CVE-2026-59903` | MEDIUM | 4.1.136.Final | 4.2.17.Final, **4.1.137.Final** | This blocks **every** PR, not any individual change, since the finding comes from a bundled dependency. It is currently the sole reason `all-pr-checks-pass` fails on open PRs (for example #1434, where the only failing step in `Build on ubuntu-latest` is "Perform image scan"). Bumping is preferred over a `trivyignore` suppression here because a patch release with the fix is already available, consistent with #1432 (4.1.136.Final), #1389 (4.1.135.Final), and #1374 (4.1.133.Final). ### Files changed - `dependencyManagement/build.gradle.kts` — `netty-bom` - `appsignals-tests/images/http-clients/netty-http-client/build.gradle.kts` — `netty-all` - `appsignals-tests/images/http-servers/netty-server/build.gradle.kts` — `netty-all` The two contract-test app pins are bumped alongside the BOM to keep them in sync, matching #1432. ## Test plan Verified locally before pushing: - `netty-bom`, `netty-all`, and `netty-codec-http` 4.1.137.Final are all published on Maven Central. - Gradle configuration succeeds (`:dependencyManagement:help` → `BUILD SUCCESSFUL`). - Dependency resolution confirms the new version takes effect, including upgrading transitives: ``` io.netty:netty-all:4.1.137.Final io.netty:netty-codec-http:4.1.137.Final io.netty:netty-codec-http:4.1.100.Final -> 4.1.137.Final (c) ``` CI provides the authoritative verification: the `pr-build` image scan should now pass, and the netty contract tests exercise the upgraded version. ## By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
haneric00
pushed a commit
that referenced
this pull request
Aug 26, 2026
## Description of changes Bumps Netty from `4.1.136.Final` to `4.1.137.Final` to fix **CVE-2026-59903**. The Trivy image scan in `pr-build` currently fails on: | Library | Vulnerability | Severity | Installed | Fixed | |---|---|---|---|---| | `io.netty:netty-codec-http` | `CVE-2026-59903` | MEDIUM | 4.1.136.Final | 4.2.17.Final, **4.1.137.Final** | This blocks **every** PR, not any individual change, since the finding comes from a bundled dependency. It is currently the sole reason `all-pr-checks-pass` fails on open PRs (for example #1434, where the only failing step in `Build on ubuntu-latest` is "Perform image scan"). Bumping is preferred over a `trivyignore` suppression here because a patch release with the fix is already available, consistent with #1432 (4.1.136.Final), #1389 (4.1.135.Final), and #1374 (4.1.133.Final). ### Files changed - `dependencyManagement/build.gradle.kts` — `netty-bom` - `appsignals-tests/images/http-clients/netty-http-client/build.gradle.kts` — `netty-all` - `appsignals-tests/images/http-servers/netty-server/build.gradle.kts` — `netty-all` The two contract-test app pins are bumped alongside the BOM to keep them in sync, matching #1432. ## Test plan Verified locally before pushing: - `netty-bom`, `netty-all`, and `netty-codec-http` 4.1.137.Final are all published on Maven Central. - Gradle configuration succeeds (`:dependencyManagement:help` → `BUILD SUCCESSFUL`). - Dependency resolution confirms the new version takes effect, including upgrading transitives: ``` io.netty:netty-all:4.1.137.Final io.netty:netty-codec-http:4.1.137.Final io.netty:netty-codec-http:4.1.100.Final -> 4.1.137.Final (c) ``` CI provides the authoritative verification: the `pr-build` image scan should now pass, and the netty contract tests exercise the upgraded version. ## By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #1372
Description of changes:
Bump netty to 4.1.133.Final to fix CVE-2026-41417. This CVE is low-risk for end-users as no attacker-controlled input reaches
setUri().Updated trivyignore to keep workflows unblocked until the next ADOT Java release (in ~2 weeks).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.