Repository navigation
Add ability to configure operator webhooks - #238
Merged
Merged
Conversation
sky333999
reviewed
Sep 8, 2025
sky333999
reviewed
Sep 8, 2025
movence
reviewed
Sep 18, 2025
| @@ -280,10 +273,7 @@ webhooks: | |||
| caBundle: {{ $ca.Cert | b64enc }} | |||
| failurePolicy: Ignore | |||
Contributor
There was a problem hiding this comment.
this doesn't get populated with agents failurepolicy?
Contributor
Author
There was a problem hiding this comment.
Wasn't being controlled before so opted to not have it be controllable
sky333999
previously approved these changes
Sep 18, 2025
movence
approved these changes
Sep 18, 2025
sky333999
approved these changes
Sep 18, 2025
movence
pushed a commit
that referenced
this pull request
Sep 24, 2025
* Add ability to configure operator webhooks * Reduce if statements on namespaceSelector * Do not specify default value for webhook create * Fix comment * Use helper function for namespaceSelector(s) * Fix null namespaceSelector override * Add admission webhooks integration tests * Operator webhook with cert manager uses helper * Address comment for variable name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes: Adds the ability to configure admissionWebhooks to be
Failure policy and namespace selector has fallback logic for backwards compatability. Essentially for the most part, the order of priority is
failurePolicy/namespaceSelectorfailurePolicy/namespaceSelector-- namely for the namespace/workload mutation webhookfailurePolicy/namespaceSelectorBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.