Repository navigation
Set Application Signals Auto Monitor to true by default - #240
Merged
Merged
Conversation
sky333999
force-pushed
the
sky333999/auto-monitor
branch
3 times, most recently
from
September 9, 2025 20:16
a14a464 to
e3eac50
Compare
sky333999
force-pushed
the
sky333999/auto-monitor
branch
2 times, most recently
from
September 9, 2025 20:39
d0e979a to
abf672f
Compare
sky333999
marked this pull request as ready for review
September 9, 2025 20:39
movence
reviewed
Sep 11, 2025
movence
left a comment
movence
left a comment
Contributor
There was a problem hiding this comment.
out of scope for this PR but should we move all tests to minikube?
| {{- end -}} | ||
| {{- end -}} | ||
| {{- if not $hasAppSignals -}} | ||
| {{- $_ := set $autoMonitorConfig "monitorAllServices" false -}} |
movence
previously approved these changes
Sep 11, 2025
…ppSignals is disabled
sky333999
force-pushed
the
sky333999/auto-monitor
branch
from
September 11, 2025 14:45
abf672f to
eb08e84
Compare
the-mann
approved these changes
Sep 11, 2025
movence
approved these changes
Sep 11, 2025
sky333999
changed the title
Contributor
Author
Yeah I was thinking the same. I guess they provide some sanity checks that the helm installation works on a real cluster, and they validate the resource counts for windows clusters, but perhaps we can ensure coverage of those with minikube by changing the node OS and getting rid of the EKS tests in a follow up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
applicationSignals->autoMonitor->monitorAllServicesby default.monitorAllServices.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.